[svn:parrot] r36237 - in trunk/lib/Parrot: Docs/Section Pmc2c Pmc2c/PMC Test/Util

[petdance at svn.parrot.org]

Author: petdance
Date: Sun Feb  1 07:38:54 2009
New Revision: 36237
URL: https://trac.parrot.org/parrot/changeset/36237

Log:
fixing little Critic complaints

Modified:
   trunk/lib/Parrot/Docs/Section/Parrot.pm
   trunk/lib/Parrot/Pmc2c/PMC/Null.pm
   trunk/lib/Parrot/Pmc2c/VTable.pm
   trunk/lib/Parrot/Test/Util/Runloop.pm

Modified: trunk/lib/Parrot/Docs/Section/Parrot.pm
==============================================================================
--- trunk/lib/Parrot/Docs/Section/Parrot.pm	Sun Feb  1 07:28:26 2009	(r36236)
+++ trunk/lib/Parrot/Docs/Section/Parrot.pm	Sun Feb  1 07:38:54 2009	(r36237)
@@ -98,6 +98,8 @@
     $dist->delete_html_docs if $delete;
 
     $self->write_html( $dist, $dist->html_docs_directory, $silent );
+
+    return;
 }
 
 =back

Modified: trunk/lib/Parrot/Pmc2c/PMC/Null.pm
==============================================================================
--- trunk/lib/Parrot/Pmc2c/PMC/Null.pm	Sun Feb  1 07:28:26 2009	(r36236)
+++ trunk/lib/Parrot/Pmc2c/PMC/Null.pm	Sun Feb  1 07:38:54 2009	(r36237)
@@ -37,7 +37,7 @@
         );
 
         # don't return anything, ever
-        my $output = <<EOC;
+        my $output = <<"EOC";
     Parrot_ex_throw_from_c_args(interp, NULL, EXCEPTION_NULL_REG_ACCESS,
         "Null PMC access in $vt_method_name()");
 EOC

Modified: trunk/lib/Parrot/Pmc2c/VTable.pm
==============================================================================
--- trunk/lib/Parrot/Pmc2c/VTable.pm	Sun Feb  1 07:28:26 2009	(r36236)
+++ trunk/lib/Parrot/Pmc2c/VTable.pm	Sun Feb  1 07:38:54 2009	(r36237)
@@ -15,7 +15,7 @@
     my $self = {};
     bless $self, $class;
     $self->build($filename) if $filename;
-    $self;
+    return $self;
 }
 
 sub build {
@@ -47,6 +47,8 @@
     $self->{'has_method'} = \%method_lookup;
     $self->{'methods'}    = \@methods;
     $self->{'names'}      = \@method_names;
+
+    return;
 }
 
 sub right_type {

Modified: trunk/lib/Parrot/Test/Util/Runloop.pm
==============================================================================
--- trunk/lib/Parrot/Test/Util/Runloop.pm	Sun Feb  1 07:28:26 2009	(r36236)
+++ trunk/lib/Parrot/Test/Util/Runloop.pm	Sun Feb  1 07:38:54 2009	(r36237)
@@ -115,6 +115,8 @@
         my $total_files = @{$args{files}};
         diag("That's $failures failed files out of $total_files files total.");
     }
+
+    return;
 }
 
 1;