[svn:parrot] r36278 - in trunk: lib/Parrot t/configure

jkeenan at svn.parrot.org jkeenan at svn.parrot.org
Mon Feb 2 11:41:56 UTC 2009


Author: jkeenan
Date: Mon Feb  2 11:41:54 2009
New Revision: 36278
URL: https://trac.parrot.org/parrot/changeset/36278

Log:
Eliminate some quotes in error messages to quiet perlcritic and allow tests to once again pass.

Modified:
   trunk/lib/Parrot/Configure.pm
   trunk/t/configure/043-verbose_step.t
   trunk/t/configure/051-fatal_step.t

Modified: trunk/lib/Parrot/Configure.pm
==============================================================================
--- trunk/lib/Parrot/Configure.pm	Mon Feb  2 10:57:57 2009	(r36277)
+++ trunk/lib/Parrot/Configure.pm	Mon Feb  2 11:41:54 2009	(r36278)
@@ -303,7 +303,7 @@
         }
     }
     else {
-        die q{Argument to "fatal-step" option must be comma-delimited string of valid configuration steps};
+        die q{Argument to fatal-step option must be comma-delimited string of valid configuration steps};
     }
     return %steps_to_die_for;
 }
@@ -323,7 +323,7 @@
         }
     }
     else {
-        die q{Argument to "verbose-step" option must be comma-delimited string of valid configuration steps};
+        die q{Argument to verbose-step option must be comma-delimited string of valid configuration steps};
     }
     return %verbose_steps;
 }

Modified: trunk/t/configure/043-verbose_step.t
==============================================================================
--- trunk/t/configure/043-verbose_step.t	Mon Feb  2 10:57:57 2009	(r36277)
+++ trunk/t/configure/043-verbose_step.t	Mon Feb  2 11:41:54 2009	(r36278)
@@ -77,7 +77,7 @@
 $conf->options->set(%args);
 eval { $conf->runsteps(); };
 like($@,
-    qr/Argument to 'verbose-step' option must be comma-delimited.*?steps/,
+    qr/Argument to verbose-step option must be comma-delimited.*?steps/,
     "Got expected error message for bad value to --verbose-step"
 );
 

Modified: trunk/t/configure/051-fatal_step.t
==============================================================================
--- trunk/t/configure/051-fatal_step.t	Mon Feb  2 10:57:57 2009	(r36277)
+++ trunk/t/configure/051-fatal_step.t	Mon Feb  2 11:41:54 2009	(r36278)
@@ -109,7 +109,7 @@
 $conf->options->set( %{$args} );
 my $rv;
 eval { $rv = $conf->runsteps; };
-like($@, qr/^Argument to 'fatal-step' option/,
+like($@, qr/^Argument to fatal-step option/,
     "Got expected error message when value to --fatal-step option was misspecified");
 
 $conf->replenish($serialized);


More information about the parrot-commits mailing list