[svn:parrot] r36906 - trunk/src/pmc

[cotto at svn.parrot.org]

Author: cotto
Date: Fri Feb 20 09:47:51 2009
New Revision: 36906
URL: https://trac.parrot.org/parrot/changeset/36906

Log:
[PMC] make the String PMC more correct, although there's still a bug somewhere

Modified:
   trunk/src/pmc/string.pmc

Modified: trunk/src/pmc/string.pmc
==============================================================================
--- trunk/src/pmc/string.pmc	Fri Feb 20 09:14:22 2009	(r36905)
+++ trunk/src/pmc/string.pmc	Fri Feb 20 09:47:51 2009	(r36906)
@@ -58,9 +58,9 @@
 
     VTABLE void destroy() {
 
-        /* There's a bug that causes this function to be called several times,
-         * even for a simple PIR hello world.  The null check/assignment allows
-         * parrot not to explode, but obviously something's goofy. */
+        /* There's a bug that causes this function to be called several times
+         * during t/pmc/thread.t.  The null check/assignment allows the test to
+         * pass, but obviously something's goofy. */
         if (PMC_data(SELF))
             mem_sys_free(PMC_data(SELF));
         PMC_data(SELF) = NULL;
@@ -119,7 +119,7 @@
 
     VTABLE PMC *clone() {
         PMC * const dest = pmc_new(INTERP, SELF->vtable->base_type);
-        PObj_custom_mark_SET(dest);
+        PObj_custom_mark_destroy_SET(dest);
         VTABLE_set_string_native(INTERP, dest, Parrot_str_copy(INTERP, SELF.get_string()));
         return dest;
     }