[svn:parrot] r37669 - in trunk/src: . pmc

cotto at svn.parrot.org cotto at svn.parrot.org
Tue Mar 24 07:20:45 UTC 2009


Author: cotto
Date: Tue Mar 24 07:20:45 2009
New Revision: 37669
URL: https://trac.parrot.org/parrot/changeset/37669

Log:
[PMC] fix/remove some obselete comments, remove more correct-by-coincidence code

Modified:
   trunk/src/hll.c
   trunk/src/pmc/integer.pmc
   trunk/src/pmc/key.pmc

Modified: trunk/src/hll.c
==============================================================================
--- trunk/src/hll.c	Tue Mar 24 07:09:26 2009	(r37668)
+++ trunk/src/hll.c	Tue Mar 24 07:20:45 2009	(r37669)
@@ -492,9 +492,6 @@
     if (hll_id == PARROT_HLL_NONE)
         return interp->root_namespace;
 
-    if (PMC_int_val(interp->HLL_namespace) < hll_id)
-        return PMCNULL;
-
     return VTABLE_get_pmc_keyed_int(interp, interp->HLL_namespace, hll_id);
 }
 

Modified: trunk/src/pmc/integer.pmc
==============================================================================
--- trunk/src/pmc/integer.pmc	Tue Mar 24 07:09:26 2009	(r37668)
+++ trunk/src/pmc/integer.pmc	Tue Mar 24 07:20:45 2009	(r37669)
@@ -342,18 +342,6 @@
 */
 
     MULTI PMC *add(Integer value, PMC *dest) {
-        /*
-         * SELF and value can both be PMCs that inherit
-         * from Integer:
-         *   cl = subclass "Integer", "MyInt"
-         * so we can't used PMC_int_val(SELF) in any of these
-         * Integer methods
-         *
-         * RT #46627
-         *   check for exact Integer type
-         *   e.g. MMD_Integer_EXACT
-         */
-
         const INTVAL a = SELF.get_integer();
         const INTVAL b = VTABLE_get_integer(INTERP, value);
         const INTVAL c = a + b;

Modified: trunk/src/pmc/key.pmc
==============================================================================
--- trunk/src/pmc/key.pmc	Tue Mar 24 07:09:26 2009	(r37668)
+++ trunk/src/pmc/key.pmc	Tue Mar 24 07:20:45 2009	(r37669)
@@ -305,7 +305,7 @@
 =item C<PMC *nextkey_keyed(PMC *key, INTVAL what)>
 
 Returns the next key relative to the location specified in C<what>.
-PMC_int_val(-1) means end of iteration.
+int_key == -1 means end of iteration.
 
 =cut
 


More information about the parrot-commits mailing list