[svn:parrot] r37775 - trunk/t/codingstd

coke at svn.parrot.org coke at svn.parrot.org
Fri Mar 27 22:27:15 UTC 2009


Author: coke
Date: Fri Mar 27 22:27:13 2009
New Revision: 37775
URL: https://trac.parrot.org/parrot/changeset/37775

Log:
[cage] remove unused variable; invert conditional to avoid code duplication.

Modified:
   trunk/t/codingstd/c_function_docs.t

Modified: trunk/t/codingstd/c_function_docs.t
==============================================================================
--- trunk/t/codingstd/c_function_docs.t	Fri Mar 27 22:07:27 2009	(r37774)
+++ trunk/t/codingstd/c_function_docs.t	Fri Mar 27 22:27:13 2009	(r37775)
@@ -37,7 +37,6 @@
 my @files = @ARGV ? @ARGV : $DIST->get_c_language_files();
 my $headerizer = Parrot::Headerizer->new;
 my @missing_docs;
-my @extra_docs;
 
 foreach my $file (@files) {
     my $path = @ARGV ? $file : $file->path;
@@ -67,15 +66,11 @@
         # if we're sent just a single file, output all function declarations
         # which aren't yet documented, otherwise just report the files
         # without docs.
-        if ( @ARGV == 1 ) {
-            if ( $buf !~ m/$decl_rx/g ) {
+        if ( $buf !~ m/$decl_rx/g ) {
+            if ( @ARGV == 1 ) {
                 push @missing_docs, "$function_decl\n";
             }
-        }
-        else {
-            # look for matching documentation.  This means the text
-            # '=item C<function_declaration>'
-            if ( $buf !~ m/$decl_rx/g ) {
+            else {
                 push @missing_docs, "$path\n";
                 last;
             }


More information about the parrot-commits mailing list