[svn:parrot] r40079 - trunk/src

bacek at svn.parrot.org bacek at svn.parrot.org
Tue Jul 14 14:20:14 UTC 2009


Author: bacek
Date: Tue Jul 14 14:20:14 2009
New Revision: 40079
URL: https://trac.parrot.org/parrot/changeset/40079

Log:
[cage] Don't use constant OrderedHash for HLL_info.

OrderedHash creates non-constant keys in push_pmc which causes GC
failures.

Modified:
   trunk/src/hll.c

Modified: trunk/src/hll.c
==============================================================================
--- trunk/src/hll.c	Tue Jul 14 14:19:53 2009	(r40078)
+++ trunk/src/hll.c	Tue Jul 14 14:20:14 2009	(r40079)
@@ -87,11 +87,6 @@
 
     PMC *entry_id;
 
-    /*
-     * ATT: all items that are owned by the HLL_info structure
-     *      have to be created as constant objects, because
-     *      this structure isn't marked by GC
-     */
     PMC * const entry = constant_pmc_new(interp, enum_class_FixedPMCArray);
 
     if (entry_name && !STRING_IS_EMPTY(entry_name)) {
@@ -133,7 +128,7 @@
 {
     ASSERT_ARGS(Parrot_init_HLL)
     interp->HLL_info      =
-        constant_pmc_new(interp, enum_class_OrderedHash);
+        pmc_new(interp, enum_class_OrderedHash);
     interp->HLL_namespace =
         constant_pmc_new(interp, enum_class_ResizablePMCArray);
 


More information about the parrot-commits mailing list