[svn:parrot] r40160 - trunk/lib/Parrot/Pmc2c/PMC
jkeenan at svn.parrot.org
jkeenan at svn.parrot.org
Sun Jul 19 23:00:32 UTC 2009
Author: jkeenan
Date: Sun Jul 19 23:00:30 2009
New Revision: 40160
URL: https://trac.parrot.org/parrot/changeset/40160
Log:
Tidy up some inline comments.
Modified:
trunk/lib/Parrot/Pmc2c/PMC/RO.pm
Modified: trunk/lib/Parrot/Pmc2c/PMC/RO.pm
==============================================================================
--- trunk/lib/Parrot/Pmc2c/PMC/RO.pm Sun Jul 19 18:14:46 2009 (r40159)
+++ trunk/lib/Parrot/Pmc2c/PMC/RO.pm Sun Jul 19 23:00:30 2009 (r40160)
@@ -43,11 +43,16 @@
my $self = bless Parrot::Pmc2c::PMC->new(
{
- parents => [ $parent->name, @{ $parent->parents } ], # prepend self to parrent
- flags => { ( %{ $parent->get_flags } ), 'is_ro' => 1 }, # copy flags, set is_ro
- name => $parent->name . "_ro", # set pmcname
- vtable => $parent->vtable, # and alias vtable
- parentname => $parent->name, # set parentname
+ # prepend self to parent
+ parents => [ $parent->name, @{ $parent->parents } ],
+ # copy flags, set is_ro
+ flags => { ( %{ $parent->get_flags } ), 'is_ro' => 1 },
+ # set pmcname
+ name => $parent->name . "_ro",
+ # and alias vtable
+ vtable => $parent->vtable,
+ # set parentname
+ parentname => $parent->name,
}
), $classname;
@@ -56,7 +61,8 @@
{
# autogenerate for nonstandard types
- # (RT#44433 is this appropriate or do we want them to each be explicitly cleared to have RO ?)
+ # (RT#44433: is this appropriate or do we want them to each be
+ # explicitly cleared to have RO ?)
no strict 'refs';
if ( !@{ ref($self) . '::ISA' } ) {
@{ ref($self) . '::ISA' } = "Parrot::Pmc2c::PMC::RO";
@@ -66,7 +72,8 @@
foreach my $vt_method ( @{ $self->vtable->methods } ) {
my $name = $vt_method->name;
- # Generate ro variant only iff we override method constantness with ":write"
+ # Generate RO variant only if we override method constantness
+ # with ":write"
next unless $parent->{has_method}{$name}
&& $parent->vtable_method_does_write($name)
&& !$parent->vtable->attrs($name)->{write};
More information about the parrot-commits
mailing list