[svn:parrot] r40475 - trunk/t/codingstd

dukeleto at svn.parrot.org dukeleto at svn.parrot.org
Mon Aug 10 03:02:26 UTC 2009


Author: dukeleto
Date: Mon Aug 10 03:02:23 2009
New Revision: 40475
URL: https://trac.parrot.org/parrot/changeset/40475

Log:
[t] Fix svn_id coding standard tests to work when parent directory is a symlink and improve portability

Modified:
   trunk/t/codingstd/svn_id.t

Modified: trunk/t/codingstd/svn_id.t
==============================================================================
--- trunk/t/codingstd/svn_id.t	Mon Aug 10 01:08:05 2009	(r40474)
+++ trunk/t/codingstd/svn_id.t	Mon Aug 10 03:02:23 2009	(r40475)
@@ -5,7 +5,7 @@
 use strict;
 use warnings;
 use Cwd;
-use File::Spec ();
+use File::Spec::Functions;
 use lib qw( . lib ../lib ../../lib );
 use Parrot::Distribution;
 use Test::More            tests => 1;
@@ -35,18 +35,18 @@
 =cut
 
 my $DIST = Parrot::Distribution->new;
-my $cwd = cwd();
+my $cwd  = getcwd(); # cwd() has some bugs when parent directory is a symbolic link
 
 # Certain files, for various reasons, cannot have an
 # SVN Id tag.  We exclude them from examination by this test.
 
 my %known_exceptions = map {
         $_ => 1,
-        ( File::Spec->catdir( $cwd, $_ ) ) => 1,
-    } qw(
-        examples/pir/quine_ord.pir
-        examples/streams/FileLines.pir
-        examples/streams/ParrotIO.pir
+        ( catdir( $cwd, $_ ) ) => 1,
+    } (
+        catfile(qw/ examples pir quine_ord.pir/),
+        catfile(qw/ examples streams FileLines.pir/),
+        catfile(qw/ examples streams ParrotIO.pir/),
     );
 
 my @files = grep { ! $known_exceptions{$_} }
@@ -59,6 +59,7 @@
             $DIST->get_pir_language_files(),
         )
 );
+
 my @no_id_files;
 
 foreach my $file (@files) {


More information about the parrot-commits mailing list