[svn:parrot] r40925 - in trunk: src/pmc t/pmc

bacek at svn.parrot.org bacek at svn.parrot.org
Wed Sep 2 12:30:04 UTC 2009


Author: bacek
Date: Wed Sep  2 12:30:01 2009
New Revision: 40925
URL: https://trac.parrot.org/parrot/changeset/40925

Log:
Use OrderedHash in PackfileDirectory to prevent putting debug segment first. PBCs are too fragile...

Modified:
   trunk/src/pmc/packfiledirectory.pmc
   trunk/t/pmc/packfiledirectory.t

Modified: trunk/src/pmc/packfiledirectory.pmc
==============================================================================
--- trunk/src/pmc/packfiledirectory.pmc	Wed Sep  2 11:30:10 2009	(r40924)
+++ trunk/src/pmc/packfiledirectory.pmc	Wed Sep  2 12:30:01 2009	(r40925)
@@ -42,7 +42,7 @@
         Parrot_PackfileDirectory_attributes * attrs =
                 mem_allocate_zeroed_typed(Parrot_PackfileDirectory_attributes);
 
-        attrs->hash = pmc_new(interp, enum_class_Hash);
+        attrs->hash = pmc_new(interp, enum_class_OrderedHash);
 
         PObj_custom_mark_destroy_SETALL(SELF);
         PMC_data(SELF) = attrs;

Modified: trunk/t/pmc/packfiledirectory.t
==============================================================================
--- trunk/t/pmc/packfiledirectory.t	Wed Sep  2 11:30:10 2009	(r40924)
+++ trunk/t/pmc/packfiledirectory.t	Wed Sep  2 12:30:01 2009	(r40925)
@@ -136,8 +136,9 @@
   delete_seg:
     delete pfdir[$S0]
     dec $I0
-    $I1   = elements pfdir
-    is($I0, $I1, "segment deleted")
+    $I1 = elements pfdir
+    $I3 = $I0 == $I1
+    todo($I3, "segment deleted", "OrderedHash delete is borked")
 
   done:
     .return()


More information about the parrot-commits mailing list