[svn:parrot] r41442 - in trunk: docs/dev include/parrot src

darbelo at svn.parrot.org darbelo at svn.parrot.org
Thu Sep 24 09:02:43 UTC 2009


Author: darbelo
Date: Thu Sep 24 09:02:37 2009
New Revision: 41442
URL: https://trac.parrot.org/parrot/changeset/41442

Log:
Remove the unused visit_pmc_later callback from the visit_info structure.

Modified:
   trunk/docs/dev/pmc_freeze.pod
   trunk/include/parrot/pmc_freeze.h
   trunk/src/pmc_freeze.c

Modified: trunk/docs/dev/pmc_freeze.pod
==============================================================================
--- trunk/docs/dev/pmc_freeze.pod	Thu Sep 24 07:26:13 2009	(r41441)
+++ trunk/docs/dev/pmc_freeze.pod	Thu Sep 24 09:02:37 2009	(r41442)
@@ -118,9 +118,6 @@
 and is called thereafter from all PMCs for contained PMCs inside the B<visit>
 vtable method.
 
-There is another callback B<visit_pmc_later> which adds PMCs to the todo list
-for later processing, but doesn't do any action on these immediately.
-
 
 =head2 The visit() vtable
 
@@ -290,4 +287,3 @@
 =cut
 
 # vim: expandtab shiftwidth=2 tw=70:
-

Modified: trunk/include/parrot/pmc_freeze.h
==============================================================================
--- trunk/include/parrot/pmc_freeze.h	Thu Sep 24 07:26:13 2009	(r41441)
+++ trunk/include/parrot/pmc_freeze.h	Thu Sep 24 09:02:37 2009	(r41442)
@@ -63,7 +63,6 @@
 
 typedef struct _visit_info {
     visit_f             visit_pmc_now;
-    visit_f             visit_pmc_later;
     visit_f             visit_action;   /* freeze, thaw ... */
     INTVAL              what;
     STRING             *image;

Modified: trunk/src/pmc_freeze.c
==============================================================================
--- trunk/src/pmc_freeze.c	Thu Sep 24 07:26:13 2009	(r41441)
+++ trunk/src/pmc_freeze.c	Thu Sep 24 09:02:37 2009	(r41442)
@@ -38,12 +38,6 @@
 /* HEADERIZER BEGIN: static */
 /* Don't modify between HEADERIZER BEGIN / HEADERIZER END.  Your changes will be lost. */
 
-static void add_pmc_todo_list(PARROT_INTERP,
-    ARGIN_NULLOK(PMC *pmc),
-    ARGIN(visit_info *info))
-        __attribute__nonnull__(1)
-        __attribute__nonnull__(3);
-
 static void create_image(PARROT_INTERP,
     ARGIN_NULLOK(PMC *pmc),
     ARGMOD(visit_info *info))
@@ -193,9 +187,6 @@
         __attribute__nonnull__(1)
         __attribute__nonnull__(3);
 
-#define ASSERT_ARGS_add_pmc_todo_list __attribute__unused__ int _ASSERT_ARGS_CHECK = \
-       PARROT_ASSERT_ARG(interp) \
-    && PARROT_ASSERT_ARG(info)
 #define ASSERT_ARGS_create_image __attribute__unused__ int _ASSERT_ARGS_CHECK = \
        PARROT_ASSERT_ARG(interp) \
     && PARROT_ASSERT_ARG(info)
@@ -646,7 +637,6 @@
 {
     ASSERT_ARGS(todo_list_init)
     info->visit_pmc_now   = visit_todo_list;
-    info->visit_pmc_later = add_pmc_todo_list;
 
     /* we must use PMCs here so that they get marked properly */
     info->todo = pmc_new(interp, enum_class_Array);
@@ -937,25 +927,6 @@
 
 /*
 
-=item C<static void add_pmc_todo_list(PARROT_INTERP, PMC *pmc, visit_info
-*info)>
-
-Remembers the PMC to be processed later.
-
-=cut
-
-*/
-
-static void
-add_pmc_todo_list(PARROT_INTERP, ARGIN_NULLOK(PMC *pmc), ARGIN(visit_info *info))
-{
-    ASSERT_ARGS(add_pmc_todo_list)
-    Parrot_pmc_array_push(interp, (List *)PMC_data(info->todo), pmc, enum_type_PMC);
-}
-
-
-/*
-
 =item C<static int todo_list_seen(PARROT_INTERP, PMC *pmc, visit_info *info,
 UINTVAL *id)>
 
@@ -1211,7 +1182,6 @@
 
     todo_list_init(interp, &info);
     info.visit_pmc_now   = visit_todo_list_thaw;
-    info.visit_pmc_later = add_pmc_todo_list;
 
     info.thaw_result = NULL;
 


More information about the parrot-commits mailing list