[svn:parrot] r41480 - in trunk: . lib/Parrot/Pmc2c t/tools

darbelo at svn.parrot.org darbelo at svn.parrot.org
Fri Sep 25 17:10:09 UTC 2009


Author: darbelo
Date: Fri Sep 25 17:10:03 2009
New Revision: 41480
URL: https://trac.parrot.org/parrot/changeset/41480

Log:
[pmc2c] Error out if the pmclass declaration differs form the pmc file's basename. This was previously a warning.
SKIP pmc2c tests that use this until we decide if they should be fixed or removed.
Remove item from DEPRECATED.pod

Modified:
   trunk/DEPRECATED.pod
   trunk/lib/Parrot/Pmc2c/Parser.pm
   trunk/t/tools/pmc2c.t

Modified: trunk/DEPRECATED.pod
==============================================================================
--- trunk/DEPRECATED.pod	Fri Sep 25 16:31:36 2009	(r41479)
+++ trunk/DEPRECATED.pod	Fri Sep 25 17:10:03 2009	(r41480)
@@ -299,21 +299,6 @@
 
 =back
 
-=head1 pmc2c syntax
-
-=over 4
-
-=item "pmclass" with name not matching file's basename [eligible in 1.5]
-
-When foo.pmc contains a the line "pmclass bar", pmc2c generates a pmc_foo.h
-but tries to include pmc_bar.h.  This is a bug, but it's possible someone out
-there is using it.  This usage will result in a warning for now; after
-the 1.4 release, this warning will be upgraded to an error.
-
-L<https://trac.parrot.org/parrot/ticket/665>
-
-=back
-
 =head1 Parrot library
 
 =over 4

Modified: trunk/lib/Parrot/Pmc2c/Parser.pm
==============================================================================
--- trunk/lib/Parrot/Pmc2c/Parser.pm	Fri Sep 25 16:31:36 2009	(r41479)
+++ trunk/lib/Parrot/Pmc2c/Parser.pm	Fri Sep 25 17:10:03 2009	(r41480)
@@ -68,8 +68,7 @@
 
     my $filebase = basename($filename);
     $filebase =~ s/\.pmc$//;
-    # Note: this can be changed to a die() after the 1.4 release. (TT #665)
-    warn("PMC filename $filebase.pmc does not match pmclass name $pmcname!\n")
+    die("PMC filename $filebase.pmc does not match pmclass name $pmcname!\n")
         unless lc($filebase) eq lc($pmcname);
     my $pmc = Parrot::Pmc2c::PMC->create($pmcname);
     $pmc->preamble( Parrot::Pmc2c::Emitter->text( $preamble, $filename, 1 ) );

Modified: trunk/t/tools/pmc2c.t
==============================================================================
--- trunk/t/tools/pmc2c.t	Fri Sep 25 16:31:36 2009	(r41479)
+++ trunk/t/tools/pmc2c.t	Fri Sep 25 17:10:03 2009	(r41480)
@@ -72,6 +72,8 @@
 
 }
 
+SKIP: {
+    skip "Test use a deprecated feature.", 12;
 pmc2c_output_like( <<'END_PMC', qr{DO NOT EDIT THIS FILE}, 'no edit warning' );
 pmclass a { }
 END_PMC
@@ -224,6 +226,7 @@
 } /* Parrot_a_class_init */
 #line 11
 END_C
+}
 
 # Local Variables:
 #   mode: cperl


More information about the parrot-commits mailing list