[svn:parrot] r41922 - branches/pcc_reapply/t/pmc

chromatic at svn.parrot.org chromatic at svn.parrot.org
Sun Oct 18 09:43:17 UTC 2009


Author: chromatic
Date: Sun Oct 18 09:43:16 2009
New Revision: 41922
URL: https://trac.parrot.org/parrot/changeset/41922

Log:
[t] Added more diagnostic info to failing test #13 for t/pmc/threads.t.

Modified:
   branches/pcc_reapply/t/pmc/threads.t

Modified: branches/pcc_reapply/t/pmc/threads.t
==============================================================================
--- branches/pcc_reapply/t/pmc/threads.t	Sun Oct 18 09:42:55 2009	(r41921)
+++ branches/pcc_reapply/t/pmc/threads.t	Sun Oct 18 09:43:16 2009	(r41922)
@@ -692,27 +692,32 @@
 
 .include 'interpinfo.pasm'
 .sub 'is'
-    .param pmc what
-    .param pmc expect
+    .param pmc    what
+    .param pmc    expect
+    .param string desc      :optional
+    .param int    have_desc :opt_flag
+
+    unless have_desc goto diagnose
+    desc = ' - ' . desc
+
+  diagnose:
     .local pmc number
     number = get_global 'test_num'
     if what == expect goto okay
     print "# got:      "
-    print what
-    print "\n"
+    say what
     print "# expected: "
-    print expect
-    print "\nnot ok "
+    say expect
+    print "not ok "
     print number
-    print "\n"
+    say desc
     inc number
     $P0 = interpinfo .INTERPINFO_CURRENT_CONT
 loop:
     $I0 = defined $P0
     if $I0 == 0 goto done
     print "    "
-    print $P0
-    print "\n"
+    say $P0
     $P0 = $P0.'continuation'()
     branch loop
 done:
@@ -721,7 +726,7 @@
     print "ok "
     print number
     inc number
-    print "\n"
+    say desc
 .end
 
 .sub setup
@@ -731,9 +736,10 @@
 .end
 
 .sub _check_sanity
+    .param string desc
     $P0 = get_global 'foo'
     $P1 = get_hll_global [ 'Foo' ], 'foo'
-    is($P0, $P1)
+    is($P0, $P1, desc)
 .end
 
 .sub mutate
@@ -743,11 +749,11 @@
 .end
 
 .sub check_sanity
-    _check_sanity()
+    _check_sanity( 'direct call' )
     $P0 = get_global '_check_sanity'
-    $P0()
+    $P0( 'call from get_global' )
     $P0 = get_hll_global [ 'Foo' ], '_check_sanity'
-    $P0()
+    $P0( 'call from get_hll_global' )
 .end
 
 .sub _check_value


More information about the parrot-commits mailing list