[svn:parrot] r42225 - trunk/src/pmc

whiteknight at svn.parrot.org whiteknight at svn.parrot.org
Mon Nov 2 18:02:49 UTC 2009


Author: whiteknight
Date: Mon Nov  2 18:02:47 2009
New Revision: 42225
URL: https://trac.parrot.org/parrot/changeset/42225

Log:
[pmc] remove some unneeded code that's been commented out for a while. Resolves RT 46659

Modified:
   trunk/src/pmc/default.pmc

Modified: trunk/src/pmc/default.pmc
==============================================================================
--- trunk/src/pmc/default.pmc	Mon Nov  2 17:27:05 2009	(r42224)
+++ trunk/src/pmc/default.pmc	Mon Nov  2 18:02:47 2009	(r42225)
@@ -108,25 +108,10 @@
 static INTVAL
 check_set_std_props(PARROT_INTERP, PMC *pmc, STRING *key, PMC *value)
 {
-    /* the quick hack below cannot be used because the string could
-       be constructed in an interpreter that is later destroyed */
-#if  0
-    /* RT #46659
-     * a quick hack, to prevent freeing that string during GC
-     * triggered in t/pmc/pmc_62.t when configured with --gc=libc
-     */
-    static STRING *ro;
-    if (!ro)
-        ro = string_make(interp, "_ro", 3, "ascii",
-            PObj_constant_FLAG|PObj_external_FLAG);
-    if (Parrot_str_equal(interp, key, ro)) {
-#else
-
     /*
      * s2 in Parrot_str_equal is freed here
      */
     if (Parrot_str_equal(interp, key, CONST_STRING(interp, "_ro"))) {
-#endif
         /* pmc should set/clear readonly */
         const INTVAL on = VTABLE_get_bool(interp, value);
 


More information about the parrot-commits mailing list