[svn:parrot] r42262 - trunk/src/pmc

chromatic at svn.parrot.org chromatic at svn.parrot.org
Thu Nov 5 07:56:03 UTC 2009


Author: chromatic
Date: Thu Nov  5 07:56:03 2009
New Revision: 42262
URL: https://trac.parrot.org/parrot/changeset/42262

Log:
[PMC] Removed RT #46665 TODO comment; there's no real value to walking the MRO
in isa checks, as the checking isa_hash member of the vtable does the same
thing.  PMCs that do something different for their parentage (Class, Object)
override the appropriate vtable entries anyway.

Modified:
   trunk/src/pmc/default.pmc

Modified: trunk/src/pmc/default.pmc
==============================================================================
--- trunk/src/pmc/default.pmc	Thu Nov  5 06:46:59 2009	(r42261)
+++ trunk/src/pmc/default.pmc	Thu Nov  5 07:56:03 2009	(r42262)
@@ -904,7 +904,6 @@
         if (!isa_hash)
             return Parrot_str_equal(interp, SELF->vtable->whoami, pmc_name);
 
-        /* RT #46665 - walk mro */
         return parrot_hash_exists(INTERP, isa_hash, (void *)pmc_name);
     }
 
@@ -921,7 +920,6 @@
 */
 
     VTABLE INTVAL isa(STRING *_class) {
-        /* RT #46665 - walk mro */
         Hash * const isa_hash = SELF->vtable->isa_hash;
         if (!isa_hash)
             return Parrot_str_equal(interp, SELF->vtable->whoami, _class);


More information about the parrot-commits mailing list