[svn:parrot] r42369 - trunk/lib/Parrot/Configure

jkeenan at svn.parrot.org jkeenan at svn.parrot.org
Sun Nov 8 14:32:07 UTC 2009


Author: jkeenan
Date: Sun Nov  8 14:32:07 2009
New Revision: 42369
URL: https://trac.parrot.org/parrot/changeset/42369

Log:
Eliminate one synthetic variable.  Clarify documentation of one method.
Typographical cleanup.

Modified:
   trunk/lib/Parrot/Configure/Trace.pm

Modified: trunk/lib/Parrot/Configure/Trace.pm
==============================================================================
--- trunk/lib/Parrot/Configure/Trace.pm	Sun Nov  8 13:25:12 2009	(r42368)
+++ trunk/lib/Parrot/Configure/Trace.pm	Sun Nov  8 14:32:07 2009	(r42369)
@@ -88,24 +88,23 @@
 sub diff_data_c {
     my ( $self, $argsref ) = @_;
     $argsref->{verbose} = 1;
-    my $trace_ref = $self->trace_data_c($argsref);
-    my @traces = @{ $trace_ref };
+    my @traces = @{ $self->trace_data_c($argsref) };
     my @results = ();
     for (my $i = 1; $i < scalar(@traces); $i++) {
         my %prior = %{$traces[$i - 1]};
         my %this  = %{$traces[$i]};
         my ($prior_key, $prior_value)   = each %prior;
-            my ($this_key,  $this_value)    = each %this;
-            $prior_value = q{} unless defined $prior_value;
-            $this_value = q{} unless defined $this_value;
-            if ($prior_value ne $this_value) {
-                push @results, {
-                    number  => $i,
-                    name    => $this_key,
-                    before  => $prior_value,
-                    after   => $this_value,
-                };
-            }
+        my ($this_key,  $this_value)    = each %this;
+        $prior_value = q{} unless defined $prior_value;
+        $this_value  = q{} unless defined $this_value;
+        if ($prior_value ne $this_value) {
+            push @results, {
+                number  => $i,
+                name    => $this_key,
+                before  => $prior_value,
+                after   => $this_value,
+            };
+        }
     }
     return \@results;
 }
@@ -422,8 +421,8 @@
 
 =item * number
 
-Number of the configuration step where the value of the given attribute
-changed; enumeration starts at C<1>, not C<0>.
+Index position of the configuration step where the value of the given attribute
+changed.  Example:  C<init::defaults> has index position C<1>.
 
 =item * name
 


More information about the parrot-commits mailing list