[svn:parrot] r42468 - in branches/configtests: config/auto config/init t/steps/auto

[jkeenan at svn.parrot.org]

Author: jkeenan
Date: Fri Nov 13 00:39:40 2009
New Revision: 42468
URL: https://trac.parrot.org/parrot/changeset/42468

Log:
Convert one Parrot::Configure attribute from get_p5 to get(x_provisional).

Modified:
   branches/configtests/config/auto/format.pm
   branches/configtests/config/init/defaults.pm
   branches/configtests/t/steps/auto/format-01.t

Modified: branches/configtests/config/auto/format.pm
==============================================================================
--- branches/configtests/config/auto/format.pm	Thu Nov 12 22:40:51 2009	(r42467)
+++ branches/configtests/config/auto/format.pm	Fri Nov 13 00:39:40 2009	(r42468)
@@ -74,7 +74,7 @@
         # Stay way from long double for now (it may be 64 or 80 bits)
         # die "long double not supported at this time, use double.";
         $nvsize   = $ldsize;
-        my $spri = $conf->data->get_p5('sPRIgldbl');
+        my $spri = $conf->data->get('sPRIgldbl_provisional');
         if ( defined $spri ) {
             $nvformat = "%.15" .  $spri;
             $nvformat =~ s/"//g;   # Perl 5's Config value has embedded double quotes

Modified: branches/configtests/config/init/defaults.pm
==============================================================================
--- branches/configtests/config/init/defaults.pm	Thu Nov 12 22:40:51 2009	(r42467)
+++ branches/configtests/config/init/defaults.pm	Fri Nov 13 00:39:40 2009	(r42468)
@@ -74,6 +74,14 @@
     # to their 'use English' names as documented in 'perlvar'.)
     $conf->data->set_p5( OSNAME => $^O );
 
+    # configtests branch:  We start to handle these things differently.
+    foreach my $orig ( qw|
+        sPRIgldbl
+    | ) {
+        $conf->data->set( qq|${orig}_provisional| => $Config{$orig} );
+    }
+
+
     my $ccdlflags = $Config{ccdlflags};
     $ccdlflags =~ s/\s*-Wl,-rpath,\S*//g if $conf->options->get('disable-rpath');
 

Modified: branches/configtests/t/steps/auto/format-01.t
==============================================================================
--- branches/configtests/t/steps/auto/format-01.t	Thu Nov 12 22:40:51 2009	(r42467)
+++ branches/configtests/t/steps/auto/format-01.t	Fri Nov 13 00:39:40 2009	(r42468)
@@ -5,7 +5,7 @@
 
 use strict;
 use warnings;
-use Test::More qw(no_plan); # tests => 16;
+use Test::More tests => 16;
 use Carp;
 use lib qw( lib t/configure/testlib );
 use_ok('config::auto::format');
@@ -96,14 +96,8 @@
         nvsize      => undef,
     );
 }
-TODO: {
-    # Getting uninitialized value warning here.
-    # Not a surprise.  We converted from an explicit 'use Config;'
-    # to get_p5 ... but since we're no longer running init::defaults in this
-    # test that value will necessarily be uninitialized.
-    local $TODO = 'Need to get rid of get_p5';
-    no warnings 'uninitialized';
-    my $p5format = '%.15' . $conf->data->get_p5('sPRIgldbl');
+{
+    my $p5format = '%.15' . $conf->data->get('sPRIgldbl_provisional');
     $p5format =~ s/"//g;; # Perl 5's Config value has embedded double quotes
     $conf->data->set( nv => 'long double' );
     eval {