[svn:parrot] r42586 - trunk/config/gen

jkeenan at svn.parrot.org jkeenan at svn.parrot.org
Fri Nov 20 00:15:56 UTC 2009


Author: jkeenan
Date: Fri Nov 20 00:15:55 2009
New Revision: 42586
URL: https://trac.parrot.org/parrot/changeset/42586

Log:
Why do a sort 3 times when you only need to do it once?

Modified:
   trunk/config/gen/config_h.pm

Modified: trunk/config/gen/config_h.pm
==============================================================================
--- trunk/config/gen/config_h.pm	Fri Nov 20 00:05:49 2009	(r42585)
+++ trunk/config/gen/config_h.pm	Fri Nov 20 00:15:55 2009	(r42586)
@@ -50,24 +50,26 @@
         feature_file   => 1
     );
 
+    my @sorted_keys = sort $conf->data->keys();
+
     $conf->data->set( TEMP_header =>
         join "\n", map { $conf->data->get($_)
                        ? "#define PARROT_HAS_HEADER_" . uc(substr $_, 2) . " 1"
                        : "#undef  PARROT_HAS_HEADER_" . uc(substr $_, 2) }
                    grep { /^i_\w+/ }
-                   sort $conf->data->keys()
+                   @sorted_keys
     );
 
     $conf->data->set( TEMP_has_config =>
         join "\n", map { "#define PARROT_" . uc($_) . " 1" }
                    grep { /^HAS_\w+/ && $conf->data->get($_) }
-                   sort $conf->data->keys()
+                   @sorted_keys
     );
 
     $conf->data->set( TEMP_d_config =>
         join "\n", map { "#define PARROT_" . uc(substr $_, 2) . " " . $conf->data->get($_) }
                    grep { /^D_\w+/ }
-                   sort $conf->data->keys()
+                   @sorted_keys
     );
 
     $conf->data->set( TEMP_cli_define =>


More information about the parrot-commits mailing list