[svn:parrot] r43874 - in branches/vtable_massacre: . src src/pmc

whiteknight at svn.parrot.org whiteknight at svn.parrot.org
Wed Feb 10 16:45:55 UTC 2010


Author: whiteknight
Date: Wed Feb 10 16:45:54 2010
New Revision: 43874
URL: https://trac.parrot.org/parrot/changeset/43874

Log:
remove set_bignum_int vtable from Integer.pmc. Last vtable I think we need to remove. Passes all tests

Modified:
   branches/vtable_massacre/DEPRECATED.pod
   branches/vtable_massacre/src/pmc/integer.pmc
   branches/vtable_massacre/src/vtable.tbl

Modified: branches/vtable_massacre/DEPRECATED.pod
==============================================================================
--- branches/vtable_massacre/DEPRECATED.pod	Wed Feb 10 16:15:07 2010	(r43873)
+++ branches/vtable_massacre/DEPRECATED.pod	Wed Feb 10 16:45:54 2010	(r43874)
@@ -52,13 +52,6 @@
 
 L<https://trac.parrot.org/parrot/ticket/264>
 
-=item various VTABLE functions [eligible in 1.5]
-
-The get_bigint, set_bigint_*, pow, i_pow and nextkey_keyed VTABLE functions are
-deprecated and will be removed.
-
-L<https://trac.parrot.org/parrot/ticket/866>
-
 =item Use of undocumented variables in class_init [eligible in 2.1]
 
 The current implementation allows the class_init vtable function body to
@@ -77,14 +70,6 @@
 
 L<https://trac.parrot.org/parrot/ticket/103>
 
-=item All bitwise VTABLE functions [eligible in 2.1]
-
-All bitwise VTABLE functions (all VTABLE functions containing C<bitwise> in
-their names) will be removed.  Equivalent functionality will by supplied by
-bitwise dynops.
-
-L<https://trac.parrot.org/parrot/ticket/1260>
-
 =item CPointer PMC [eligible in 2.1]
 
 And all uses in the Parrot calling conventions.

Modified: branches/vtable_massacre/src/pmc/integer.pmc
==============================================================================
--- branches/vtable_massacre/src/pmc/integer.pmc	Wed Feb 10 16:15:07 2010	(r43873)
+++ branches/vtable_massacre/src/pmc/integer.pmc	Wed Feb 10 16:45:54 2010	(r43874)
@@ -221,10 +221,6 @@
 
 Morphs the integer to a C<Boolean> and sets the value from C<value>.
 
-=item C<void set_bigint_int(INTVAL value)>
-
-Morphs the integer to a C<BigInt> and sets the value from C<value>.
-
 =item C<void set_string_native(STRING *value)>
 
 Morphs the integer to a C<String> and sets the value from C<value>.
@@ -245,11 +241,6 @@
     }
 
 
-    VTABLE void set_bignum_int(INTVAL value) {
-        pmc_reuse(INTERP, SELF, enum_class_BigInt, 0);
-        SELF.set_integer_native(value);
-    }
-
 
     VTABLE void set_string_native(STRING *value) {
         pmc_reuse(INTERP, SELF, enum_class_String, 0);
@@ -375,14 +366,14 @@
     }
 
 
-    VTABLE void i_add_int(INTVAL b) { //
-        const INTVAL a = SELF.get_integer(); //
-        const INTVAL c = a + b; //
-
-        if ((c^a) >= 0 || (c^b) >= 0) //
-            VTABLE_set_integer_native(INTERP, SELF, c); //
-        else { //
-            PMC *temp; //
+    VTABLE void i_add_int(INTVAL b) {
+        const INTVAL a = SELF.get_integer();
+        const INTVAL c = a + b;
+
+        if ((c^a) >= 0 || (c^b) >= 0)
+            VTABLE_set_integer_native(INTERP, SELF, c);
+        else {
+            PMC *temp;
             maybe_throw_overflow_error(interp);
             SELF = upgrade_self_to_bignum(interp, SELF);
             VTABLE_i_add_int(interp, SELF, b);

Modified: branches/vtable_massacre/src/vtable.tbl
==============================================================================
--- branches/vtable_massacre/src/vtable.tbl	Wed Feb 10 16:15:07 2010	(r43873)
+++ branches/vtable_massacre/src/vtable.tbl	Wed Feb 10 16:45:54 2010	(r43874)
@@ -70,10 +70,6 @@
 void set_number_keyed_int(INTVAL key, FLOATVAL value)
 void set_number_keyed_str(STRING* key, FLOATVAL value)
 
-void set_bignum_int(INTVAL value)
-void set_bignum_num(FLOATVAL value)
-void set_bignum_str(STRING* value)
-
 void set_string_native(STRING* value)
 void assign_string_native(STRING* value)
 void set_string_keyed(PMC* key, STRING* value)


More information about the parrot-commits mailing list