[svn:parrot] r44451 - in branches/rm_cflags: compilers/imcc config/auto config/gen/makefiles

coke at svn.parrot.org coke at svn.parrot.org
Wed Feb 24 07:18:02 UTC 2010


Author: coke
Date: Wed Feb 24 07:18:02 2010
New Revision: 44451
URL: https://trac.parrot.org/parrot/changeset/44451

Log:
Don't run with "unused" by default. (it wasn't in trunk).

Move imclexer's warning overrides into auto::warnings.
Don't bother overriding unused if we're not using it.

imclexer's overrides are not (at the moment) respected, doc it.

Modified:
   branches/rm_cflags/compilers/imcc/Rules.mak
   branches/rm_cflags/config/auto/warnings.pm
   branches/rm_cflags/config/gen/makefiles/root.in

Modified: branches/rm_cflags/compilers/imcc/Rules.mak
==============================================================================
--- branches/rm_cflags/compilers/imcc/Rules.mak	Wed Feb 24 07:07:17 2010	(r44450)
+++ branches/rm_cflags/compilers/imcc/Rules.mak	Wed Feb 24 07:18:02 2010	(r44451)
@@ -91,6 +91,7 @@
     $(PARROT_H_HEADERS)
 
 ## SUFFIX OVERRIDE - Warnings (This is generated code)
+## XXX except we can't do that in a raw .mak file; we'd need to generate  it.
 compilers/imcc/imclexer$(O) : \
     compilers/imcc/imclexer.c \
     compilers/imcc/cfg.h \
@@ -104,9 +105,6 @@
     compilers/imcc/unit.h \
     $(INC_DIR)/oplib/ops.h \
     $(PARROT_H_HEADERS)
-	$(CC) $(CFLAGS) $(CC_SHARED) -Wno-switch-default -Wno-unused \
-    -Wno-format-nonliteral \
-    -I$(@D) $(CC_O_OUT) $@ -c compilers/imcc/imclexer.c
 
 compilers/imcc/imcparser$(O) : \
     compilers/imcc/cfg.h \

Modified: branches/rm_cflags/config/auto/warnings.pm
==============================================================================
--- branches/rm_cflags/config/auto/warnings.pm	Wed Feb 24 07:07:17 2010	(r44450)
+++ branches/rm_cflags/config/auto/warnings.pm	Wed Feb 24 07:18:02 2010	(r44451)
@@ -141,7 +141,6 @@
         -Wtrigraphs
         -Wundef
         -Wunknown-pragmas
-        -Wunused
         -Wvariadic-macros
         -Wwrite-strings
     );
@@ -179,6 +178,7 @@
         -Wno-multichar
         -Wno-pointer-sign
         -Wunreachable-code
+        -Wunused
         -Wunused-function
         -Wunused-label
         -Wunused-value
@@ -190,10 +190,15 @@
 
     $gcc->{'todo'} = $gpp->{'todo'} = {
         '-Wformat-nonliteral' => [
+            'compilers/imcc/imclexer.c',
             'src/spf_render.c',
-        ] 
+        ],
+        '-Wno-switch-default' => [
+            'compilers/imcc/imclexer.c',
+        ],
     };
 
+
     $data->{'warnings'}{'gcc'} = $gcc;
     $data->{'warnings'}{'gpp'} = $gpp;
 

Modified: branches/rm_cflags/config/gen/makefiles/root.in
==============================================================================
--- branches/rm_cflags/config/gen/makefiles/root.in	Wed Feb 24 07:07:17 2010	(r44450)
+++ branches/rm_cflags/config/gen/makefiles/root.in	Wed Feb 24 07:18:02 2010	(r44451)
@@ -1459,15 +1459,12 @@
 
 # core_ops depends upon config.h so that it gets updated along with
 # updates to config.h's version numbers
-## SUFFIX OVERRIDE - Warnings.
 src/ops/core_ops$(O) : src/ops/core_ops.c \
     include/pmc/pmc_callcontext.h \
     include/pmc/pmc_continuation.h \
     include/pmc/pmc_parrotlibrary.h \
     src/io/io_private.h $(INC_DIR)/dynext.h $(INC_DIR)/embed.h \
     $(INC_DIR)/oplib/core_ops.h $(INC_DIR)/runcore_api.h
-	$(CC) $(CFLAGS) $(CC_WARN) @cc_shared@ -Wno-unused-parameter -Wno-unused-variable \
-    -I$(@D) @cc_o_out@$@ -c src/ops/core_ops.c
 
 # .h files are built along with .c
 $(INC_DIR)/oplib/core_ops.h: src/ops/core_ops.c


More information about the parrot-commits mailing list