[svn:parrot] r44507 - in trunk: src/pmc t/pmc

[NotFound at svn.parrot.org]

Author: NotFound
Date: Fri Feb 26 22:50:34 2010
New Revision: 44507
URL: https://trac.parrot.org/parrot/changeset/44507

Log:
rename oplib method ops_by_shortname to op_family and add some tests

Modified:
   trunk/src/pmc/oplib.pmc
   trunk/t/pmc/oplib.t

Modified: trunk/src/pmc/oplib.pmc
==============================================================================
--- trunk/src/pmc/oplib.pmc	Fri Feb 26 22:10:09 2010	(r44506)
+++ trunk/src/pmc/oplib.pmc	Fri Feb 26 22:50:34 2010	(r44507)
@@ -97,7 +97,7 @@
         return INTERP->op_lib->op_count;
     }
 
-    METHOD ops_by_shortname(STRING *shortname)
+    METHOD op_family(STRING *shortname)
     {
         char *sname = Parrot_str_to_cstring(INTERP, shortname);
         const op_lib_t * const op_lib = INTERP->op_lib;

Modified: trunk/t/pmc/oplib.t
==============================================================================
--- trunk/t/pmc/oplib.t	Fri Feb 26 22:10:09 2010	(r44506)
+++ trunk/t/pmc/oplib.t	Fri Feb 26 22:50:34 2010	(r44507)
@@ -14,10 +14,12 @@
 
 .sub main :main
     .include 'test_more.pir'
-    plan(3)
+    plan(5)
     new_oplib()
     get_end()
     get_no_opcode()
+    family_end()
+    family_no_opcode()
 .end
 
 .sub new_oplib
@@ -41,6 +43,25 @@
     ok($I0, "get non existent opcode fails")
 .end
 
+.sub family_end
+    $P0 = new ['OpLib']
+    # Assumption: we'll always have an end opcode.
+    $P1 = $P0.'op_family'('end')
+    $I0 = isnull $P1
+    dec $I0
+    unless $I0 goto done
+    $I0 = elements $P1
+done:
+    is($I0, 1, "'end' family is not null and has 1 element")
+.end
+
+.sub family_no_opcode
+    $P0 = new ['OpLib']
+    $P1 = $P0.'op_family'('hopeweneverhaveopcodesnamedlikethis')
+    $I0 = isnull $P1
+    ok($I0, "non existent opcode family is null")
+.end
+
 # Local Variables:
 #   mode: pir
 #   fill-column: 100