[svn:parrot] r44646 - in branches/pcc_hackathon_6Mar10: include/parrot src/call

allison at svn.parrot.org allison at svn.parrot.org
Fri Mar 5 14:28:44 UTC 2010


Author: allison
Date: Fri Mar  5 14:28:44 2010
New Revision: 44646
URL: https://trac.parrot.org/parrot/changeset/44646

Log:
[pcc] Remove function only left in place to support now-removed
deprecated functions.

Modified:
   branches/pcc_hackathon_6Mar10/include/parrot/call.h
   branches/pcc_hackathon_6Mar10/src/call/args.c

Modified: branches/pcc_hackathon_6Mar10/include/parrot/call.h
==============================================================================
--- branches/pcc_hackathon_6Mar10/include/parrot/call.h	Fri Mar  5 14:09:50 2010	(r44645)
+++ branches/pcc_hackathon_6Mar10/include/parrot/call.h	Fri Mar  5 14:28:44 2010	(r44646)
@@ -157,16 +157,6 @@
 /* Don't modify between HEADERIZER BEGIN / HEADERIZER END.  Your changes will be lost. */
 
 PARROT_EXPORT
-void Parrot_pcc_append_result(PARROT_INTERP,
-    ARGIN(PMC *sig_object),
-    ARGIN(STRING *type),
-    ARGIN(void *result))
-        __attribute__nonnull__(1)
-        __attribute__nonnull__(2)
-        __attribute__nonnull__(3)
-        __attribute__nonnull__(4);
-
-PARROT_EXPORT
 PARROT_WARN_UNUSED_RESULT
 PARROT_CANNOT_RETURN_NULL
 PMC* Parrot_pcc_build_sig_object_from_op(PARROT_INTERP,

Modified: branches/pcc_hackathon_6Mar10/src/call/args.c
==============================================================================
--- branches/pcc_hackathon_6Mar10/src/call/args.c	Fri Mar  5 14:09:50 2010	(r44645)
+++ branches/pcc_hackathon_6Mar10/src/call/args.c	Fri Mar  5 14:28:44 2010	(r44646)
@@ -2881,82 +2881,6 @@
 
 /*
 
-=item C<void Parrot_pcc_append_result(PARROT_INTERP, PMC *sig_object, STRING
-*type, void *result)>
-
-Helper function between old and new style PCC to append return pointer to signature.
-
-To be removed with deprecated functions.
-
-=cut
-
-*/
-
-PARROT_EXPORT
-void
-Parrot_pcc_append_result(PARROT_INTERP, ARGIN(PMC *sig_object), ARGIN(STRING *type),
-        ARGIN(void *result))
-{
-    ASSERT_ARGS(Parrot_pcc_append_result)
-    STRING *full_sig;
-    PMC    *return_flags;
-    INTVAL  return_flags_size;
-    INTVAL  int_type;
-
-    Parrot_String return_flags_name = Parrot_str_new_constant(interp, "return_flags");
-    Parrot_String sig_name          = Parrot_str_new_constant(interp, "signature");
-
-    full_sig = VTABLE_get_string(interp, sig_object);
-    /* Append ->[T] */
-    Parrot_str_concat(interp, full_sig, Parrot_str_new_constant(interp, "->"), 0);
-    Parrot_str_concat(interp, full_sig, type, 0);
-
-    /* Update returns_flag */
-    return_flags = VTABLE_get_attr_str(interp, sig_object, return_flags_name);
-    if (PMC_IS_NULL(return_flags)) {
-        /* Create return_flags for single element */
-        return_flags = Parrot_pmc_new(interp, enum_class_FixedIntegerArray);
-        return_flags_size = 0;
-        VTABLE_set_integer_native(interp, return_flags, 1);
-        VTABLE_set_attr_str(interp, sig_object, return_flags_name, return_flags);
-    }
-    else {
-        /* Extend return_flags by one element */
-        return_flags_size = VTABLE_elements(interp, return_flags);
-        VTABLE_set_integer_native(interp, return_flags, return_flags_size + 1);
-    }
-    switch (Parrot_str_indexed(interp, type, 0)) {
-      case 'I':
-        VTABLE_set_integer_keyed_int(interp, return_flags, return_flags_size,
-                    PARROT_ARG_INTVAL);
-        int_type = PARROT_ARG_INTVAL;
-        break;
-      case 'N':
-        VTABLE_set_integer_keyed_int(interp, return_flags, return_flags_size,
-                    PARROT_ARG_FLOATVAL);
-        int_type = PARROT_ARG_FLOATVAL;
-        break;
-      case 'S':
-        VTABLE_set_integer_keyed_int(interp, return_flags, return_flags_size,
-                    PARROT_ARG_STRING);
-        int_type = PARROT_ARG_STRING;
-        break;
-      case 'P':
-        VTABLE_set_integer_keyed_int(interp, return_flags, return_flags_size,
-                    PARROT_ARG_PMC);
-        int_type = PARROT_ARG_PMC;
-        break;
-      default:
-        Parrot_ex_throw_from_c_args(interp, NULL,
-                EXCEPTION_INVALID_OPERATION,
-                "invalid signature string element!");
-    }
-
-    csr_push_pointer(interp, sig_object, result, int_type);
-}
-
-/*
-
 =back
 
 =head1 SEE ALSO


More information about the parrot-commits mailing list