[svn:parrot] r45192 - trunk/src/dynpmc

[petdance at svn.parrot.org]

Author: petdance
Date: Fri Mar 26 21:15:07 2010
New Revision: 45192
URL: https://trac.parrot.org/parrot/changeset/45192

Log:
consting

Modified:
   trunk/src/dynpmc/gdbmhash.pmc

Modified: trunk/src/dynpmc/gdbmhash.pmc
==============================================================================
--- trunk/src/dynpmc/gdbmhash.pmc	Fri Mar 26 05:57:58 2010	(r45191)
+++ trunk/src/dynpmc/gdbmhash.pmc	Fri Mar 26 21:15:07 2010	(r45192)
@@ -1,5 +1,5 @@
 /* gdbmhash.pmc
- *  Copyright (C) 2005-2009, Parrot Foundation.
+ *  Copyright (C) 2005-2010, Parrot Foundation.
  *  SVN Info
  *     $Id$
  *  Overview:
@@ -28,8 +28,8 @@
 
 =head2 fetch
 
-get_integer_keyed() and get_number_keyed() probably don't make any sense,
-as integers usually can't be converted.
+C<get_integer_keyed()> and C<get_number_keyed()> probably don't make
+any sense, as integers usually can't be converted.
 
 When a PMC is requested, a String PMC is returned.
 
@@ -62,14 +62,13 @@
 
 */
 
-static STRING* make_hash_key(PARROT_INTERP, NOTNULL(PMC * key))
+static STRING* make_hash_key(PARROT_INTERP, ARGIN(PMC * key))
 {
     if (key)
         return VTABLE_get_string(interp, key);
 
     Parrot_ex_throw_from_c_args(interp, NULL, EXCEPTION_OUT_OF_BOUNDS,
         "Hash: Cannot use NULL key");
-
 }
 
 
@@ -269,9 +268,8 @@
 */
 
     VTABLE void set_pmc_keyed(PMC* key, PMC* value) {
-        STRING *temp;
+        STRING * const temp = VTABLE_get_string(interp, value);
 
-        temp = VTABLE_get_string(interp, value);
         SELF.set_string_keyed(key, temp);
     }
 
@@ -286,8 +284,8 @@
 */
 
     VTABLE PMC* get_pmc_keyed(PMC* key) {
-        STRING * ret_string = SELF.get_string_keyed(key);
-        PMC *ret_pmc = Parrot_pmc_new(interp, enum_class_String);
+        STRING * const ret_string = SELF.get_string_keyed(key);
+        PMC    * const ret_pmc    = Parrot_pmc_new(interp, enum_class_String);
 
         VTABLE_set_string_native(interp, ret_pmc, ret_string);
 
@@ -305,9 +303,8 @@
 */
 
     VTABLE void set_integer_keyed(PMC* key, INTVAL value) {
-        PMC *temp;
+        PMC * const temp = Parrot_pmc_new(interp, enum_class_String);
 
-        temp = Parrot_pmc_new(interp, enum_class_String);
         VTABLE_set_integer_native(interp, temp, value);
         SELF.set_pmc_keyed(key, temp);
     }
@@ -324,9 +321,8 @@
 */
 
     VTABLE void set_number_keyed(PMC* key, FLOATVAL value) {
-        PMC *temp;
+        PMC * const temp = Parrot_pmc_new(interp, enum_class_String);
 
-        temp = Parrot_pmc_new(interp, enum_class_String);
         VTABLE_set_number_native(interp, temp, value);
         SELF.set_pmc_keyed(key, temp);
     }