[svn:parrot] r45454 - in trunk: include/parrot src/call

[petdance at svn.parrot.org]

Author: petdance
Date: Thu Apr  8 19:51:43 2010
New Revision: 45454
URL: https://trac.parrot.org/parrot/changeset/45454

Log:
In fact, Parrot_pcc_build_call_from_c_args should NOT be ignored. If it is called without saving the return value, then it is dead code. The warning is a flag that we need to change that dead code.

Modified:
   trunk/include/parrot/call.h
   trunk/src/call/args.c

Modified: trunk/include/parrot/call.h
==============================================================================
--- trunk/include/parrot/call.h	Thu Apr  8 19:39:45 2010	(r45453)
+++ trunk/include/parrot/call.h	Thu Apr  8 19:51:43 2010	(r45454)
@@ -157,8 +157,8 @@
 /* Don't modify between HEADERIZER BEGIN / HEADERIZER END.  Your changes will be lost. */
 
 PARROT_EXPORT
+PARROT_WARN_UNUSED_RESULT
 PARROT_CANNOT_RETURN_NULL
-PARROT_IGNORABLE_RESULT
 PMC* Parrot_pcc_build_call_from_c_args(PARROT_INTERP,
     ARGIN_NULLOK(PMC *signature),
     ARGIN(const char *sig),

Modified: trunk/src/call/args.c
==============================================================================
--- trunk/src/call/args.c	Thu Apr  8 19:39:45 2010	(r45453)
+++ trunk/src/call/args.c	Thu Apr  8 19:51:43 2010	(r45454)
@@ -658,8 +658,8 @@
 */
 
 PARROT_EXPORT
+PARROT_WARN_UNUSED_RESULT
 PARROT_CANNOT_RETURN_NULL
-PARROT_IGNORABLE_RESULT
 PMC*
 Parrot_pcc_build_call_from_c_args(PARROT_INTERP,
         ARGIN_NULLOK(PMC *signature), ARGIN(const char *sig), ...)