[svn:parrot] r45760 - in branches/immutable_strings_part1/lib/Parrot: . Configure/Options/Test

petdance at svn.parrot.org petdance at svn.parrot.org
Sat Apr 17 16:28:31 UTC 2010


Author: petdance
Date: Sat Apr 17 16:28:31 2010
New Revision: 45760
URL: https://trac.parrot.org/parrot/changeset/45760

Log:
quiet some Critic warnings

Modified:
   branches/immutable_strings_part1/lib/Parrot/Configure/Options/Test/Prepare.pm
   branches/immutable_strings_part1/lib/Parrot/Distribution.pm

Modified: branches/immutable_strings_part1/lib/Parrot/Configure/Options/Test/Prepare.pm
==============================================================================
--- branches/immutable_strings_part1/lib/Parrot/Configure/Options/Test/Prepare.pm	Sat Apr 17 16:28:11 2010	(r45759)
+++ branches/immutable_strings_part1/lib/Parrot/Configure/Options/Test/Prepare.pm	Sat Apr 17 16:28:31 2010	(r45760)
@@ -78,6 +78,8 @@
                 ? qq|$secondlevel-$number|
                 : $number;
             $steps_tests_complex{$category}{$class}{$final}++;
+
+            return;
         }
     } # END wanted()
     finddepth( \&wanted, ( $steps_dir ) );

Modified: branches/immutable_strings_part1/lib/Parrot/Distribution.pm
==============================================================================
--- branches/immutable_strings_part1/lib/Parrot/Distribution.pm	Sat Apr 17 16:28:11 2010	(r45759)
+++ branches/immutable_strings_part1/lib/Parrot/Distribution.pm	Sat Apr 17 16:28:31 2010	(r45760)
@@ -1,4 +1,4 @@
-# Copyright (C) 2004-2009, Parrot Foundation.
+# Copyright (C) 2004-2010, Parrot Foundation.
 # $Id$
 
 =head1 NAME
@@ -248,13 +248,13 @@
                 # and make a hash out of the directories
                 my %dirs =
                     map { ( ( File::Spec->splitpath($_) )[1] => 1 ) }
-                    grep { m|(?i)(?:$filter_ext)| } $self->_dist_files;
+                    grep { m/(?i)(?:$filter_ext)/ } $self->_dist_files;
 
                 # Filter out ignored directories
                 # and return the results
                 my @dirs = sort
                     map  { $self->directory_with_name($_) }
-                    grep { !m|(?:$filter_dir)| }
+                    grep { !m/(?:$filter_dir)/ }
                     keys %dirs;
                 return @dirs;
             };
@@ -293,7 +293,7 @@
                 # and return a sorted list of filenames
                 my @files = sort
                     map  { $self->file_with_name($_) }
-                    grep { m|(?i)(?:$filter_ext)| }
+                    grep { m/(?i)(?:$filter_ext)/ }
                     $self->_dist_files;
                 return @files;
             };
@@ -334,7 +334,7 @@
     # and return a sorted list of filenames
     my @files = sort
         map  { $self->file_with_name($_) }
-        grep { m|[/\\]makefiles[/\\][a-z]+\.in$| }
+        grep { m{[/\\]makefiles[/\\][a-z]+\.in$} }
         $self->_dist_files;
     return @files;
 }


More information about the parrot-commits mailing list