[svn:parrot] r47034 - in branches/ns_func_cleanup: docs include/parrot src

[whiteknight at svn.parrot.org]

Author: whiteknight
Date: Wed May 26 23:56:15 2010
New Revision: 47034
URL: https://trac.parrot.org/parrot/changeset/47034

Log:
Parrot_store_global_s -> Parrot_ns_store_global. This function is heavily underused (only used twice, in the same file where it's defined) so we might eventually want to make it go away

Modified:
   branches/ns_func_cleanup/docs/embed.pod
   branches/ns_func_cleanup/include/parrot/global.h
   branches/ns_func_cleanup/src/global.c

Modified: branches/ns_func_cleanup/docs/embed.pod
==============================================================================
--- branches/ns_func_cleanup/docs/embed.pod	Wed May 26 23:43:49 2010	(r47033)
+++ branches/ns_func_cleanup/docs/embed.pod	Wed May 26 23:56:15 2010	(r47034)
@@ -303,7 +303,7 @@
 Find and return a global called C<name> in the namespace C<namespace>.  Returns
 C<PMCNULL> if not found.
 
-=item C<void Parrot_store_global_n(PARROT_INTERP, PMC namespace, Parrot_String name, Parrot_PMC val)>
+=item C<void Parrot_ns_store_global(PARROT_INTERP, PMC namespace, Parrot_String name, Parrot_PMC val)>
 
 Store the PMC C<val> into the namespace PMC C<namespace> with name C<globalname>.
 
@@ -1533,7 +1533,7 @@
 
 =item C<Parrot_srand>
 
-=item C<Parrot_store_global_n>
+=item C<Parrot_ns_store_global>
 
 =item C<Parrot_store_global_s>
 

Modified: branches/ns_func_cleanup/include/parrot/global.h
==============================================================================
--- branches/ns_func_cleanup/include/parrot/global.h	Wed May 26 23:43:49 2010	(r47033)
+++ branches/ns_func_cleanup/include/parrot/global.h	Wed May 26 23:56:15 2010	(r47034)
@@ -126,7 +126,7 @@
         __attribute__nonnull__(1);
 
 PARROT_EXPORT
-void Parrot_store_global_n(PARROT_INTERP,
+void Parrot_ns_store_global(PARROT_INTERP,
     ARGIN_NULLOK(PMC *ns),
     ARGIN_NULLOK(STRING *globalname),
     ARGIN_NULLOK(PMC *val))
@@ -183,7 +183,7 @@
     , PARROT_ASSERT_ARG(_namespace))
 #define ASSERT_ARGS_Parrot_ns_set_global __attribute__unused__ int _ASSERT_ARGS_CHECK = (\
        PARROT_ASSERT_ARG(interp))
-#define ASSERT_ARGS_Parrot_store_global_n __attribute__unused__ int _ASSERT_ARGS_CHECK = (\
+#define ASSERT_ARGS_Parrot_ns_store_global __attribute__unused__ int _ASSERT_ARGS_CHECK = (\
        PARROT_ASSERT_ARG(interp))
 #define ASSERT_ARGS_Parrot_store_global_s __attribute__unused__ int _ASSERT_ARGS_CHECK = (\
        PARROT_ASSERT_ARG(interp))

Modified: branches/ns_func_cleanup/src/global.c
==============================================================================
--- branches/ns_func_cleanup/src/global.c	Wed May 26 23:43:49 2010	(r47033)
+++ branches/ns_func_cleanup/src/global.c	Wed May 26 23:56:15 2010	(r47034)
@@ -571,7 +571,7 @@
 
 /*
 
-=item C<void Parrot_store_global_n(PARROT_INTERP, PMC *ns, STRING *globalname,
+=item C<void Parrot_ns_store_global(PARROT_INTERP, PMC *ns, STRING *globalname,
 PMC *val)>
 
 Store the PMC C<val> into the namespace PMC C<ns> with name C<globalname>.
@@ -582,10 +582,10 @@
 
 PARROT_EXPORT
 void
-Parrot_store_global_n(PARROT_INTERP, ARGIN_NULLOK(PMC *ns),
+Parrot_ns_store_global(PARROT_INTERP, ARGIN_NULLOK(PMC *ns),
         ARGIN_NULLOK(STRING *globalname), ARGIN_NULLOK(PMC *val))
 {
-    ASSERT_ARGS(Parrot_store_global_n)
+    ASSERT_ARGS(Parrot_ns_store_global)
 #if DEBUG_GLOBAL
     if (globalname)
         Parrot_io_printf(interp, "store_global name '%Ss'\n", globalname);
@@ -619,7 +619,7 @@
                                          Parrot_get_ctx_HLL_namespace(interp),
                                          str_key);
 
-    Parrot_store_global_n(interp, ns, globalname, val);
+    Parrot_ns_store_global(interp, ns, globalname, val);
 
     /* TT #1225 - method cache invalidation should be a namespace function */
     Parrot_invalidate_method_cache(interp, str_key);
@@ -818,7 +818,7 @@
         STRING * const ns_entry_name = sub->ns_entry_name;
         PMC    * const nsname        = sub->namespace_name;
 
-        Parrot_store_global_n(interp, ns, ns_entry_name, sub_pmc);
+        Parrot_ns_store_global(interp, ns, ns_entry_name, sub_pmc);
 
         /* TT #1224:
            TEMPORARY HACK - cache invalidation should be a namespace function */