[svn:parrot] r47185 - in branches/tt1452_configure_debug: config/auto t/steps/auto

jkeenan at svn.parrot.org jkeenan at svn.parrot.org
Mon May 31 02:56:12 UTC 2010


Author: jkeenan
Date: Mon May 31 02:56:11 2010
New Revision: 47185
URL: https://trac.parrot.org/parrot/changeset/47185

Log:
Update config step and test file to reflect change in handling of verbose debugging output.

Modified:
   branches/tt1452_configure_debug/config/auto/neg_0.pm
   branches/tt1452_configure_debug/t/steps/auto/neg_0-01.t

Modified: branches/tt1452_configure_debug/config/auto/neg_0.pm
==============================================================================
--- branches/tt1452_configure_debug/config/auto/neg_0.pm	Mon May 31 02:48:46 2010	(r47184)
+++ branches/tt1452_configure_debug/config/auto/neg_0.pm	Mon May 31 02:56:11 2010	(r47185)
@@ -33,7 +33,6 @@
 
 sub runstep {
     my ( $self, $conf ) = @_;
-    my ( $verbose ) = $conf->options->get('verbose');
     $conf->cc_gen('config/auto/neg_0/test_c.in');
     eval { $conf->cc_build( q{} ); };
     my $has_neg_0 = 0;
@@ -43,7 +42,6 @@
             $conf,
             $test,
             $has_neg_0,
-            $verbose,
         );
     }
     $conf->cc_clean();
@@ -54,10 +52,11 @@
 
 sub _evaluate_cc_run {
     my $self = shift;
-    my ($conf, $test, $has_neg_0, $verbose) = @_;
+    my ($conf, $test, $has_neg_0) = @_;
     $has_neg_0 = ($test =~ m/^-0/ ? 1 : 0);
     $self->set_result( $has_neg_0 ? 'yes' : 'no' );
-    print $has_neg_0 ? ' (yes) ' : ' (no) ' if $verbose;
+    my $output = $has_neg_0 ? ' (yes) ' : ' (no) ';
+    $conf->debug($output);
     return $has_neg_0;
 }
 

Modified: branches/tt1452_configure_debug/t/steps/auto/neg_0-01.t
==============================================================================
--- branches/tt1452_configure_debug/t/steps/auto/neg_0-01.t	Mon May 31 02:48:46 2010	(r47184)
+++ branches/tt1452_configure_debug/t/steps/auto/neg_0-01.t	Mon May 31 02:56:11 2010	(r47185)
@@ -55,11 +55,10 @@
 
 my $d_neg_0;
 my $orig_has_neg_0 = 0;
-my $verbose = $conf->data->get('verbose');
 
 $d_neg_0 = '-0';
 
-is( $step->_evaluate_cc_run($conf, $d_neg_0, $orig_has_neg_0, $verbose),
+is( $step->_evaluate_cc_run($conf, $d_neg_0, $orig_has_neg_0),
     1,
     '_evaluate_cc_run() completed satisfactorily' );
 
@@ -67,7 +66,7 @@
 
 $d_neg_0 = '0';
 
-is( $step->_evaluate_cc_run($conf, $d_neg_0, $orig_has_neg_0, $verbose),
+is( $step->_evaluate_cc_run($conf, $d_neg_0, $orig_has_neg_0),
     0,
     '_evaluate_cc_run() completed satisfactorily' );
 is( $step->result(), 'no', 'Got expected result' );
@@ -85,7 +84,6 @@
 $conf->options->set( %{$args} );
 $step = test_step_constructor_and_description($conf);
 
-$verbose = $conf->options->get('verbose');
 my $has_neg_0;
 
 $d_neg_0 = '-0';
@@ -94,7 +92,7 @@
     capture(
         sub {
             $has_neg_0 = $step->_evaluate_cc_run(
-                $conf, $d_neg_0, $orig_has_neg_0, $verbose
+                $conf, $d_neg_0, $orig_has_neg_0
             ),
         },
         \$stdout,
@@ -111,7 +109,7 @@
     capture(
         sub {
             $has_neg_0 = $step->_evaluate_cc_run(
-                $conf, $d_neg_0, $orig_has_neg_0, $verbose
+                $conf, $d_neg_0, $orig_has_neg_0
             ),
         },
         \$stdout,


More information about the parrot-commits mailing list