[svn:parrot] r47441 - in branches/gsoc_nfg/src/string: . encoding

darbelo at svn.parrot.org darbelo at svn.parrot.org
Mon Jun 7 23:59:18 UTC 2010


Author: darbelo
Date: Mon Jun  7 23:59:18 2010
New Revision: 47441
URL: https://trac.parrot.org/parrot/changeset/47441

Log:
Move a TODO to the place where the fix would go.

Modified:
   branches/gsoc_nfg/src/string/api.c
   branches/gsoc_nfg/src/string/encoding/nfg.c

Modified: branches/gsoc_nfg/src/string/api.c
==============================================================================
--- branches/gsoc_nfg/src/string/api.c	Mon Jun  7 23:58:35 2010	(r47440)
+++ branches/gsoc_nfg/src/string/api.c	Mon Jun  7 23:59:18 2010	(r47441)
@@ -2580,7 +2580,7 @@
     reserved = string_max_bytes(interp, result, srclen);
     Parrot_gc_allocate_string_storage(interp, result, reserved);
     result->bufused = reserved;
-    result->extra = NULL; // TODO: Check wether we'll need a grapheme table here and create one if we will.
+    result->extra = NULL;
 
     src->encoding->iter_init(interp, src, &itersrc);
     encoding->iter_init(interp, result, &iterdest);

Modified: branches/gsoc_nfg/src/string/encoding/nfg.c
==============================================================================
--- branches/gsoc_nfg/src/string/encoding/nfg.c	Mon Jun  7 23:58:35 2010	(r47440)
+++ branches/gsoc_nfg/src/string/encoding/nfg.c	Mon Jun  7 23:59:18 2010	(r47441)
@@ -507,6 +507,7 @@
     s[pos++] = (UChar32) c;
     ++i->charpos;
     i->bytepos = pos * sizeof (UChar32);
+    // TODO: properly compose stuff here.
 #else
     UNUSED(i);
     no_ICU_lib(interp);


More information about the parrot-commits mailing list