[svn:parrot] r48723 - trunk/t/codingstd

[chromatic]

On Sunday 29 August 2010 at 18:07, jkeenan  wrote:


> Log:
> Have test output tell us how many TODOs, etc., remain.
> 
> Modified:
>    trunk/t/codingstd/c_todo.t
> 
> Modified: trunk/t/codingstd/c_todo.t
> 
==============================================================================
> --- trunk/t/codingstd/c_todo.t	Mon Aug 30 01:06:50 2010	(r48722)
> +++ trunk/t/codingstd/c_todo.t	Mon Aug 30 01:07:21 2010	(r48723)
> @@ -60,7 +60,7 @@
>  
>  my $num_failed_files = scalar keys %failed_files;
>  TODO: {
> -    local $TODO = 'some todos remain';
> +    local $TODO = scalar(@fixme) . ' todos remain';

That's better as:

	local $TODO = @fixme . ' todos remain';
  
>  ok( !scalar(@fixme), 'FIXME strings' )

... and that's better as:

	ok( !@fixme, 'FIXME strings' );

... or better as:

	is( @fixme, 0, 'FIXME strings' );

... depending on how you want to structure the diagnostics.

-- c