[svn:parrot] r49057 - trunk/t/library

whiteknight at svn.parrot.org whiteknight at svn.parrot.org
Thu Sep 16 12:46:45 UTC 2010


Author: whiteknight
Date: Thu Sep 16 12:46:45 2010
New Revision: 49057
URL: https://trac.parrot.org/parrot/changeset/49057

Log:
t/library/archive_zip.t was failing with an unhandled exception if parrot is compiled without zlib support builtin. I added an exception handler and finalize_p to fail more gracefully, but that doesn't appear to have worked. I needed to add an exit_i to the end to force a graceful exit from the inner runloop.

Modified:
   trunk/t/library/archive_zip.t

Modified: trunk/t/library/archive_zip.t
==============================================================================
--- trunk/t/library/archive_zip.t	Thu Sep 16 12:39:03 2010	(r49056)
+++ trunk/t/library/archive_zip.t	Thu Sep 16 12:46:45 2010	(r49057)
@@ -19,11 +19,23 @@
 .sub 'main' :main
     .include 'test_more.pir'
 
+    push_eh no_zlib_support
     load_bytecode 'Archive/Zip.pir'
-
+    pop_eh
+    goto have_zlib_support
+  no_zlib_support:
+    .get_results($P0)
+    pop_eh
+    finalize $P0
+    plan(1)
+    ok(1, "Test irrelevant without zlib support built-in")
+    goto zlib_test_end
+  have_zlib_support:
     plan(14)
     test_new()
     test_pack()
+  zlib_test_end:
+    exit 0
 .end
 
 .sub 'test_new'


More information about the parrot-commits mailing list