[parrot/parrot] d170bd: [t] Fix Parrot_PMC_modulus test and add Parrot_PMC...

noreply at github.com noreply at github.com
Sat Jan 1 21:40:45 UTC 2011


Branch: refs/heads/leto/embed_grant
Home:   https://github.com/parrot/parrot

Commit: d170bd59650ea85187de7717c87a20df09f103c7
    https://github.com/parrot/parrot/commit/d170bd59650ea85187de7717c87a20df09f103c7
Author: Jonathan "Duke" Leto <jonathan at leto.net>
Date:   2011-01-01 (Sat, 01 Jan 2011)

Changed paths:
  M t/src/embed.t

Log Message:
-----------
[t] Fix Parrot_PMC_modulus test and add Parrot_PMC_divide

It seems that these functions take three arguments, but nothing
is done with the third argument. The function signatures of
Parrot_PMC_modulus, Parrot_PMC_divide and all similar functions
should probably be deprecated and either changed to:

1) take 2 arguments and return 1 value
2) return void and take 3 arguments

I think for unification with future design principles (such as
fixed width opcodes that return void), that option 2) should
be persued, but this issue needs to be brought up on parrot-dev.




More information about the parrot-commits mailing list