[parrot/parrot] 1a28d8: [lib] Marked unused return value as UNUSED.

noreply at github.com noreply at github.com
Mon Jan 31 07:11:35 UTC 2011


Branch: refs/heads/master
Home:   https://github.com/parrot/parrot

Commit: 1a28d8a0c8ec12b5e583fcbdbd99ae14b3cf3ec9
    https://github.com/parrot/parrot/commit/1a28d8a0c8ec12b5e583fcbdbd99ae14b3cf3ec9
Author: chromatic <chromatic at wgz.org>
Date:   2011-01-30 (Sun, 30 Jan 2011)

Changed paths:
  M lib/Parrot/Pmc2c/PCCMETHOD.pm

Log Message:
-----------
[lib] Marked unused return value as UNUSED.

This should resolve several Coverity warnings such as CID #1279.


Commit: 16ccd1d3860f74f72c4f5b96d70531161fb90b8b
    https://github.com/parrot/parrot/commit/16ccd1d3860f74f72c4f5b96d70531161fb90b8b
Author: chromatic <chromatic at wgz.org>
Date:   2011-01-30 (Sun, 30 Jan 2011)

Changed paths:
  M lib/Parrot/Pmc2c/PCCMETHOD.pm

Log Message:
-----------
[lib] Avoided double-declaration of a PMC param.

This should close several Coverity reports, such as CID #1287. There's still a
logical question in this code regarding the value of passing the PMC as a
parameter to these functions, then immediately retrieving it from the call
object, but that's a much larger change more worthwhile when we rewrite the PMC
to C emitter.


Commit: 01fef9c43591e0aa8f45dd60f313fbeae31eaef6
    https://github.com/parrot/parrot/commit/01fef9c43591e0aa8f45dd60f313fbeae31eaef6
Author: chromatic <chromatic at wgz.org>
Date:   2011-01-30 (Sun, 30 Jan 2011)

Changed paths:
  M src/gc/alloc_resources.c

Log Message:
-----------
[GC] Simplified function for debug/non-debug cases.

The motivation for this change is to avoid a side effect in the assert,
specifically PARROT_ASSERT(--count), reported by Coverity in CID #441. Rather
than wrapping #ifdefs around the decrement, it seems clearer to extract the
normal behavior of the loop for non-debugging builds and to provide an
alternate version in the case of a debugging build.




More information about the parrot-commits mailing list