[parrot/parrot] 487e9d: Eliminate Parrot::Pmc2c::Attribute.

GitHub noreply at github.com
Wed Jun 13 23:33:57 UTC 2012


  Branch: refs/heads/master
  Home:   https://github.com/parrot/parrot
  Commit: 487e9d02e5050953028c41cea3edca0aff820541
      https://github.com/parrot/parrot/commit/487e9d02e5050953028c41cea3edca0aff820541
  Author: jkeenan <jkeenan at cpan.org>
  Date:   2012-06-09 (Sat, 09 Jun 2012)

  Changed paths:
    M MANIFEST
    M lib/Parrot/Pmc2c/PMC.pm
    M lib/Parrot/Pmc2c/Parser.pm

  Log Message:
  -----------
  Eliminate Parrot::Pmc2c::Attribute.

ack-ing showed that none of this method's packages was invoked more than once.
Hence, we can either move them to the package in which they are invoked or
eliminate them entirely in favor of simply passing their arguments to callers
as needed.

Invocation of name() in Parrot::Pmc2c::PMC re-coded to be a hash dereference
rather than a method call.

generate_start(), generate_declaration(), generate_end() and
generate_accessor() become Parrot::Pmc2c::PMC internal methods.

new() was called only once, within Parrot/Pmc2c/Parser.pm.  It never did
anything other than guarantee that all four of its key-value pairs had defined
values.  Rework its invocation.


  Commit: e6e2d763c626eed83c8b263a1bb0ca3bb21d575b
      https://github.com/parrot/parrot/commit/e6e2d763c626eed83c8b263a1bb0ca3bb21d575b
  Author: jkeenan <jkeenan at cpan.org>
  Date:   2012-06-13 (Wed, 13 Jun 2012)

  Changed paths:
    M MANIFEST
    M lib/Parrot/Pmc2c/PMC.pm
    M lib/Parrot/Pmc2c/Parser.pm

  Log Message:
  -----------
  Merge branch 'attribute_generate'


Compare: https://github.com/parrot/parrot/compare/328cbafb883d...e6e2d763c626


More information about the parrot-commits mailing list