[parrot/parrot] f4a2ff: Parrot::Pmc2c::MULTI::rewrite_multi_sub() is invok...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/parrot/parrot
  Commit: f4a2ff1c36a2af16150f9c507836e7237200e950
      https://github.com/parrot/parrot/commit/f4a2ff1c36a2af16150f9c507836e7237200e950
  Author: jkeenan <jkeenan at cpan.org>
  Date:   2012-06-09 (Sat, 09 Jun 2012)

  Changed paths:
    M lib/Parrot/Pmc2c/MULTI.pm
    M lib/Parrot/Pmc2c/Parser.pm

  Log Message:
  -----------
  Parrot::Pmc2c::MULTI::rewrite_multi_sub() is invoked only once, in
Parrot::Pmc2c::Parser::find_methods().  The way it is written would lead one
to believe that its first argument was an object of its own class, which it is
not. The first argument is a Parrot::Pmc2c::Method object.  So inside
rewrite_multi_sub(), rename $self -> $method to be more self-documenting.


  Commit: 2ad68dd6d47c90a40afec07304e1150f4a63542f
      https://github.com/parrot/parrot/commit/2ad68dd6d47c90a40afec07304e1150f4a63542f
  Author: jkeenan <jkeenan at cpan.org>
  Date:   2012-06-09 (Sat, 09 Jun 2012)

  Changed paths:
    M lib/Parrot/Pmc2c/PCCMETHOD.pm
    M lib/Parrot/Pmc2c/Parser.pm

  Log Message:
  -----------
  Parrot::Pmc2c::MULTI::rewrite_pccmethod() and mangle_name() are invoked only
once each, in Parrot::Pmc2c::Parser::find_methods().  The way they are written
would lead one to believe that their first arguments were objects of the
Parrot::Pmc2c::MULTI class, which they are not. In each case, the first
argument is a Parrot::Pmc2c::Method object.  So inside rewrite_multi_sub(),
rename $self -> $method to be more self-documenting.

In addition, mangle_name() makes no use of its second argument, $pmc.  So
eliminate it.


  Commit: a4ffcce82820ad8073087eeb64aa2e2b5f81ea96
      https://github.com/parrot/parrot/commit/a4ffcce82820ad8073087eeb64aa2e2b5f81ea96
  Author: jkeenan <jkeenan at cpan.org>
  Date:   2012-06-09 (Sat, 09 Jun 2012)

  Changed paths:
    M MANIFEST
    R lib/Parrot/Pmc2c/MULTI.pm
    M lib/Parrot/Pmc2c/PCCMETHOD.pm
    M lib/Parrot/Pmc2c/Parser.pm

  Log Message:
  -----------
  Parrot::Pmc2c::MULTI::rewrite_multi_sub() is invoked only once, inside
Parrot::Pmc2c::Parser::find_methods.  Let's move it to Parrot::Pmc2c::PCCMETHOD
where it can reside along two other subroutines invoked within find_methods.
This enables us to eliminate lib/Parrot/Pmc2c/MULTI.pm entirely.


  Commit: e2bd11aab4ab9e604746bdbc9529c3e0e887ba1d
      https://github.com/parrot/parrot/commit/e2bd11aab4ab9e604746bdbc9529c3e0e887ba1d
  Author: jkeenan <jkeenan at cpan.org>
  Date:   2012-06-09 (Sat, 09 Jun 2012)

  Changed paths:
    M config/auto/pmc.pm
    M lib/Parrot/Pmc2c/Parser.pm

  Log Message:
  -----------
  Eliminate remaining references to Parrot::Pmc2c::MULTI.


  Commit: 144115ee9cc2ba74a011f2912368157145b59c1c
      https://github.com/parrot/parrot/commit/144115ee9cc2ba74a011f2912368157145b59c1c
  Author: jkeenan <jkeenan at cpan.org>
  Date:   2012-06-13 (Wed, 13 Jun 2012)

  Changed paths:
    M MANIFEST
    M config/auto/pmc.pm
    R lib/Parrot/Pmc2c/MULTI.pm
    M lib/Parrot/Pmc2c/PCCMETHOD.pm
    M lib/Parrot/Pmc2c/Parser.pm

  Log Message:
  -----------
  Merge branch 'eliminate_multi'


Compare: https://github.com/parrot/parrot/compare/e6e2d763c626...144115ee9cc2