[parrot/parrot] 7ee353: Fix socket tests, though I'm not happy with this f...

GitHub noreply at github.com
Sat Jun 16 11:41:46 UTC 2012


  Branch: refs/heads/whiteknight/io_cleanup1
  Home:   https://github.com/parrot/parrot
  Commit: 7ee35303bfc5815cfa205fd589785059a472bf84
      https://github.com/parrot/parrot/commit/7ee35303bfc5815cfa205fd589785059a472bf84
  Author: Whiteknight <wknight8111 at gmail.com>
  Date:   2012-06-16 (Sat, 16 Jun 2012)

  Changed paths:
    M include/parrot/io.h
    M src/io/buffer.c
    M src/io/filehandle.c
    M src/io/pipe.c
    M src/io/stringhandle.c
    M src/io/utilities.c

  Log Message:
  -----------
  Fix socket tests, though I'm not happy with this fix.

If we do a recv for X bytes but only receive Y (Y < X), we shouldn't try to recv again to get more because recv can hang if there's no data incoming. Notice that this 'fix' fails for very large reads where we fill the buffer and could legitimately recv more bytes but do not.





More information about the parrot-commits mailing list