[parrot/parrot] 655a88: Fix a major mistake I added in readline.

GitHub noreply at github.com
Sat Jul 21 16:04:20 UTC 2012


  Branch: refs/heads/whiteknight/io_cleanup1
  Home:   https://github.com/parrot/parrot
  Commit: 655a88057557a7a13176c4e4a9fb62648bcef969
      https://github.com/parrot/parrot/commit/655a88057557a7a13176c4e4a9fb62648bcef969
  Author: Whiteknight <wknight8111 at gmail.com>
  Date:   2012-07-21 (Sat, 21 Jul 2012)

  Changed paths:
    M src/io/buffer.c

  Log Message:
  -----------
  Fix a major mistake I added in readline.

When reading from the buffer, we have to return the number of bytes up to the delimiter, not the number of characters. For multi-byte characters, readline was omitting some bytes. This fixes most remaining test failures.


  Commit: 8a10dbed83fe1d8cec78ba8820179ccc7337d34d
      https://github.com/parrot/parrot/commit/8a10dbed83fe1d8cec78ba8820179ccc7337d34d
  Author: Whiteknight <wknight8111 at gmail.com>
  Date:   2012-07-21 (Sat, 21 Jul 2012)

  Changed paths:
    M src/io/api.c
    M src/io/buffer.c
    M src/pmc/handle.pmc

  Log Message:
  -----------
  Final fixes for readline. coretest now passes 100% again.

Fix Handle.encoding() to update the encoding of the record_separator STRING ATTR too. This prevents, for example, cases where we are trying to readline '\n' on a UTF-16 string and getting an odd number of bytes back from the buffer.


Compare: https://github.com/parrot/parrot/compare/2a953cac16e3...8a10dbed83fe


More information about the parrot-commits mailing list