[parrot/parrot] 1e44cc: [GH #832] Probe for broken snprintf %+..u in mingw...

GitHub noreply at github.com
Mon Sep 17 15:28:29 UTC 2012


  Branch: refs/heads/rurban/broken-sprintf-uplus-gh832
  Home:   https://github.com/parrot/parrot
  Commit: 1e44cc13774e254f234930c0447f0e2268c26a9f
      https://github.com/parrot/parrot/commit/1e44cc13774e254f234930c0447f0e2268c26a9f
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2012-09-17 (Mon, 17 Sep 2012)

  Changed paths:
    M config/auto/snprintf.pm
    M config/auto/snprintf/test_c.in
    M config/gen/config_h/feature_h.in
    M src/string/spf_render.c

  Log Message:
  -----------
  [GH #832] Probe for broken snprintf %+..u in mingw and fix it.

snprintf %+u fails on mingw only. t/op/sprintf.t test 217 and
t/op/string.t: 196, 198 (now 197)
The + is always printed, but should not.

As it works okay in win32 (with msvcrt.ll) and cygwin (cygwin1.dll)
on the same system, I assumed it's mingw only snprintf/sprintf wrapper
issue.

Probe in auto:snprintf for PARROT_HAS_BROKEN_SPRINTF_UPLUS and skip
the '+' in %+..u in spf_render.c.

But the probe is not yet correct. It passes on mingw, but should fail.





More information about the parrot-commits mailing list