[parrot/parrot] 538223: '1' added to result message is superfluous; revert...

GitHub noreply at github.com
Tue Oct 2 02:01:31 UTC 2012


  Branch: refs/heads/master
  Home:   https://github.com/parrot/parrot
  Commit: 538223b3634e2436bf8457ac81ac21b17e038497
      https://github.com/parrot/parrot/commit/538223b3634e2436bf8457ac81ac21b17e038497
  Author: James E Keenan <jkeenan at cpan.org>
  Date:   2012-10-01 (Mon, 01 Oct 2012)

  Changed paths:
    M config/auto/llvm.pm

  Log Message:
  -----------
  '1' added to result message is superfluous; revert.

The second argument passed to auto::llvm::_handle_result() is merely a Boolean
used to determine whether the result message displayed as part of
Configure.pl's output should be set to 'yes' or 'no'.  Consequently, a result
of 'yes, 1' conveys nothing above or beyond 'yes'.  Reverting the modification
(which was also causing failures in t/steps/auto/llvm-01.t).


  Commit: c3af31cbedacecc3f7e7fa4c257dadf01cac55f1
      https://github.com/parrot/parrot/commit/c3af31cbedacecc3f7e7fa4c257dadf01cac55f1
  Author: James E Keenan <jkeenan at cpan.org>
  Date:   2012-10-01 (Mon, 01 Oct 2012)

  Changed paths:
    M MANIFEST
    M config/auto/alignof.pm
    A t/steps/auto/alignof-01.t

  Log Message:
  -----------
  Add minimal tests for auto::alignof.

Configuration step auto::alignof was added to master without a corresponding
test file under t/steps.  Add that file; update MANIFEST.  Make indentation in
config/auto/alignof.pm consistent.

Note: Running the newly added steps test shows that internal subroutine
test_if_needed throws a warning, at least when we are not trying to compile
with clang.  The warning is:

  value for '@TEMP_type@' in config/auto/alignof/test_c.in is undef at
    lib/Parrot/Configure/Compiler.pm line 584, <$in> line 55.

This indicates a possible problem with config/auto/alignof/test_c.in.


Compare: https://github.com/parrot/parrot/compare/bd6851e96fcb...c3af31cbedac


More information about the parrot-commits mailing list