[parrot/parrot] d68069: [tools] Use 'Configure'd values for cover, gcov et...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/parrot/parrot
  Commit: d6806949f91ae913be37464a16b3fd67c36b2839
      https://github.com/parrot/parrot/commit/d6806949f91ae913be37464a16b3fd67c36b2839
  Author: Paul Cochrane <paultcochrane at gmail.com>
  Date:   2013-04-20 (Sat, 20 Apr 2013)

  Changed paths:
    M tools/dev/make_cover.pl

  Log Message:
  -----------
  [tools] Use 'Configure'd values for cover, gcov etc.

make_cover.pl used the code coverage commands directly in order to run the
programs cover, gcov, gcov2perl etc.  It should have been using the values
determined in the 'perl Configure.pl' step.  Now the configured values are
used instead of the bare program names.


  Commit: 5768b1920763d131bb436031961797863b8bd758
      https://github.com/parrot/parrot/commit/5768b1920763d131bb436031961797863b8bd758
  Author: Paul Cochrane <paultcochrane at gmail.com>
  Date:   2013-04-20 (Sat, 20 Apr 2013)

  Changed paths:
    M config/gen/makefiles/root.in

  Log Message:
  -----------
  [configure] 'cover_new' target replaces 'cover'

cover_new uses the tools/dev/make_cover.pl script to process the files
created from a coverage test run.  This is much more flexible and easier to
maintain than trying to get 'make' to do the right thing.

Also, the 'cover' target was running only the runcore tests and not the
standard test suite (a.k.a 'make test'), hence the output from 'make cover'
wasn't telling us what was being covered in 'make test', leading to
unexpected and confusing results (e.g. that extend_vtable wasn't being
tested at all).  The principle of least surprise suggests that 'make cover'
should run the same tests that 'make test' runs.


  Commit: 34280e91049c8151f2ab0e7ad2b63d01a662277c
      https://github.com/parrot/parrot/commit/34280e91049c8151f2ab0e7ad2b63d01a662277c
  Author: Paul Cochrane <paultcochrane at gmail.com>
  Date:   2013-04-20 (Sat, 20 Apr 2013)

  Changed paths:
    M config/gen/makefiles/root.in

  Log Message:
  -----------
  [configure] fullcover_new Makefile target should also consider FULLCOVER_DIRS

The 'fullcover_new' target only used the COVER_DIRS list of directories,
which comes from running the 'cover' target.  The 'fullcover_new' target now
considers the same list of directories as the 'fullcover' target, in order
to be consistent with it.


  Commit: ab3f702beb62a9860b13042d1f1419db7e72f1f9
      https://github.com/parrot/parrot/commit/ab3f702beb62a9860b13042d1f1419db7e72f1f9
  Author: Paul Cochrane <paultcochrane at gmail.com>
  Date:   2013-04-20 (Sat, 20 Apr 2013)

  Changed paths:
    M config/gen/makefiles/root.in

  Log Message:
  -----------
  [configure] 'fullcover_new' make target replaces 'cover'

The 'fullcover_new' target reproduces the 'fullcover' target but uses
tools/dev/make_cover.pl to run the coverage tools (gcov, cover, etc.).  This
is much more flexible and easier to maintain than shell code within the
makefile.

Further, the old 'fullcover' target didn't make use of the predefined
variables set by 'perl Configure.pl', which make_cover.pl does.  Also, a
temporary directory is used by make_cover.pl for the coverage tools' output
which replaces the current behaviour of putting everything in the base build
directory.  Also, the old 'fullcover' target actually covered more files
than it was asked to and other files were repeatedly covered; this change
corrects this behaviour, however means that one has to be very explicit
about which directories need to be considered.


  Commit: 438b1c4b40387f6c6967a669711f7934b881d481
      https://github.com/parrot/parrot/commit/438b1c4b40387f6c6967a669711f7934b881d481
  Author: Jonathan "Duke" Leto <jonathan at leto.net>
  Date:   2013-04-20 (Sat, 20 Apr 2013)

  Changed paths:
    M config/gen/makefiles/root.in
    M tools/dev/make_cover.pl

  Log Message:
  -----------
  Merge pull request #960 from paultcochrane/ptc/cover_new_to_cover

Replace 'cover' make targets with 'cover_new' targets


Compare: https://github.com/parrot/parrot/compare/965cb1bb4521...438b1c4b4038