[parrot/parrot] 750f53: [cage] change UNUSED(arg) to SHIM in the decl #105...

GitHub noreply at github.com
Mon Mar 10 18:51:28 UTC 2014


  Branch: refs/heads/rurban/SHIM-gh1052
  Home:   https://github.com/parrot/parrot
  Commit: 750f536a1d68f13e55a0edeeec6593ba44eac3b5
      https://github.com/parrot/parrot/commit/750f536a1d68f13e55a0edeeec6593ba44eac3b5
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-03-10 (Mon, 10 Mar 2014)

  Changed paths:
    M compilers/imcc/imcc.y
    M compilers/imcc/imcparser.c
    M compilers/imcc/parser_util.c
    M compilers/imcc/pbc.c
    M compilers/imcc/pcc.c
    M compilers/imcc/symreg.c
    M include/parrot/debugger.h
    M include/parrot/encoding.h
    M include/parrot/oplib/core_ops.h
    M include/parrot/oplib/ops.h
    M include/parrot/opsenum.h
    M include/parrot/packfile.h
    M src/call/context.c
    M src/call/ops.c
    M src/debug.c
    M src/embed/pmc.c
    M src/gc/alloc_resources.c
    M src/gc/gc_gms.c
    M src/gc/gc_inf.c
    M src/gc/gc_private.h
    M src/gc/mark_sweep.c
    M src/gc/string_gc.c
    M src/interp/api.c
    M src/io/api.c
    M src/io/io_private.h
    M src/io/pipe.c
    M src/io/socket.c
    M src/io/stringhandle.c
    M src/io/utilities.c
    M src/ops/core.ops
    M src/ops/core_ops.c
    M src/ops/experimental.ops
    M src/packfile/api.c
    M src/packfile/pf_items.c
    M src/platform/generic/exec.c
    M src/pmc/bigint.pmc
    M src/pmc/imageiothaw.pmc
    M src/pmc/integer.pmc
    M src/runcore/cores.c
    M src/string/encoding.c
    M src/string/encoding/shared.c
    M src/string/encoding/shared.h
    M src/utils.c

  Log Message:
  -----------
  [cage] change UNUSED(arg) to SHIM in the decl #1052

UNUSED just adds code to please the compiler unused warnings, but we should
really declare the args as such with SHIM()
We need UNUSED only in .pmc declaration because we have no control over
SHIM, the pmc2c compiler does it for us there.

Also do not return unused values, rather cast to (void) and
strip PARROT_WARN_UNUSED_RESULT attributes on them.

UNUSED Exceptions: io vtable methods keep the 2nd handle arg. The C abi defines
caller cleanup, so we could declare some of them with empty args, but for
the sake of API sanity we accept at least 2 args.

Headerizer does not grok #ifdef (yet), so we need to UNUSED some args.


  Commit: 1f0d1e849f8fa06494db3b1c7503cfc961102589
      https://github.com/parrot/parrot/commit/1f0d1e849f8fa06494db3b1c7503cfc961102589
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-03-10 (Mon, 10 Mar 2014)

  Changed paths:
    M compilers/imcc/imc.h
    M compilers/imcc/parser.h
    M lib/Parrot/Pmc2c/PMC.pm
    M src/global_setup.c

  Log Message:
  -----------
  [cage] remove redundant duplicate declarations

seen with --cage


Compare: https://github.com/parrot/parrot/compare/cd26cab16b7f...1f0d1e849f8f


More information about the parrot-commits mailing list