[parrot/parrot] 183023: [ops] find_codepoint: search more u_charFromName c...

GitHub noreply at github.com
Sat Jun 14 21:15:51 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/parrot/parrot
  Commit: 1830239472f4f8382a2bb76deb56893b9408b231
      https://github.com/parrot/parrot/commit/1830239472f4f8382a2bb76deb56893b9408b231
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-13 (Fri, 13 Jun 2014)

  Changed paths:
    M src/ops/core_ops.c
    M src/ops/string.ops
    M t/op/string_cclass.t
    M t/op/stringu.t

  Log Message:
  -----------
  [ops] find_codepoint: search more u_charFromName choices

icu stores character names in 4 tables: U_UNICODE_CHAR_NAME, U_EXTENDED_CHAR_NAME,
U_CHAR_NAME_ALIAS, U_UNICODE_10_CHAR_NAME
but does not allow to search for all name aliases (at least until 52) for alias-only names,
like for empty-named control characters. See [GH #1075]

All perl6 control character names, like
"LINE FEED (LF)" "CARRIAGE RETURN (CR)" "NULL" "NEXT LINE (NEL)" "CHARACTER TABULATION"
will fail.


  Commit: 5cb6219016c19e70b50f8737f74ee39ebbf2220f
      https://github.com/parrot/parrot/commit/5cb6219016c19e70b50f8737f74ee39ebbf2220f
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-14 (Sat, 14 Jun 2014)

  Changed paths:
    M MANIFEST
    M config/gen/makefiles/root.in
    A include/parrot/namealias.h
    M src/ops/core_ops.c
    M src/ops/string.ops
    A src/string/namealias.c
    A src/string/namealias_c.in
    M t/op/stringu.t

  Log Message:
  -----------
  [ops] find_codepoint: Missing Unicode NameAlias lookup

For non-icu supported control character name aliases.
Fixes [GH #1075]
Uses a gperf generated perfect hash from a UnicodeData.txt
generated list of control character names. Optimized
to be loaded from shared libraries.


  Commit: 7bc3a07e031b1fd98904870f77412db1636fbb71
      https://github.com/parrot/parrot/commit/7bc3a07e031b1fd98904870f77412db1636fbb71
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-14 (Sat, 14 Jun 2014)

  Changed paths:
    M ChangeLog
    M MANIFEST
    M config/gen/makefiles/root.in
    M include/parrot/encoding.h
    M include/parrot/namealias.h
    M lib/Parrot/Test/Pod.pm
    M src/ops/core_ops.c
    M src/ops/string.ops
    M src/string/encoding.c
    M src/string/namealias.c
    M src/string/namealias_c.in
    M t/codingstd/c_parens.t
    M t/codingstd/pod_syntax.t
    A tools/build/namealias_c.pl

  Log Message:
  -----------
  [GH #1075] find_codepoint namealias

add a tools/build/namealias_c.pl to manually cleanup the generated
gperf c file for inline, C++ compat and codingstd_tests.

add Parrot_str_internal_find_codepoint to src/string/encoding.c
(not namealias.c because headerizer doesn't like namealias_c.in)

use that also for the non-ICU codepath, so that at least some names are
found. This can be used later to add all names to namealias for non-ICU builds.

remove inline from namealias. This doesn't need to be fast, just small.

fixup some weird codingstd tests for namealias. podchecker passes but Pod::Simple not.
c_parens.t misparses namealias_c.in as functions

make headerizer and bootstrap-ops.


  Commit: 6e28025e0fefc92a5543e6c76024a10d58dab638
      https://github.com/parrot/parrot/commit/6e28025e0fefc92a5543e6c76024a10d58dab638
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-14 (Sat, 14 Jun 2014)

  Changed paths:
    M config/gen/makefiles/root.in

  Log Message:
  -----------
  Makefile: remove special @cc_shared@ as it included in $(CFLAGS) now


  Commit: 6606cfb85752c9c9e81eacfbba77f6454de6b316
      https://github.com/parrot/parrot/commit/6606cfb85752c9c9e81eacfbba77f6454de6b316
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-14 (Sat, 14 Jun 2014)

  Changed paths:
    M src/string/namealias.c
    M src/string/namealias_c.in
    M tools/build/namealias_c.pl

  Log Message:
  -----------
  namealias: exit with 0 if gperf is not available. we have a fallback

should fix the smokers


  Commit: 26d6bf9674ed3345470c5c37d79f6aae8fce5b1e
      https://github.com/parrot/parrot/commit/26d6bf9674ed3345470c5c37d79f6aae8fce5b1e
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-14 (Sat, 14 Jun 2014)

  Changed paths:
    M t/op/stringu.t

  Log Message:
  -----------
  [test] fix wrong t/op/stringu.t testcount --without-icu

this test works now also without ICU.
improve the wording also.


  Commit: efe4eb7789b36f74c923511fbc24200ffe8d4f0e
      https://github.com/parrot/parrot/commit/efe4eb7789b36f74c923511fbc24200ffe8d4f0e
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-14 (Sat, 14 Jun 2014)

  Changed paths:
    M ChangeLog
    M MANIFEST
    M config/gen/makefiles/root.in
    M include/parrot/encoding.h
    A include/parrot/namealias.h
    M lib/Parrot/Test/Pod.pm
    M src/ops/core_ops.c
    M src/ops/string.ops
    M src/string/encoding.c
    A src/string/namealias.c
    A src/string/namealias_c.in
    M t/codingstd/c_parens.t
    M t/codingstd/pod_syntax.t
    M t/op/string_cclass.t
    M t/op/stringu.t
    A tools/build/namealias_c.pl

  Log Message:
  -----------
  Merge branch 'smoke-me/icu-namealias-gh1075'

Smoked good on travis: https://travis-ci.org/parrot/parrot/builds/27586300
solaris http://smolder.parrot.org/app/projects/report_details/44602
and darwin. without and without gperf and ICU.

But cygwin and windows have other unrelated problems. Need to be fixed later.


Compare: https://github.com/parrot/parrot/compare/2fa788d5275f...efe4eb7789b3


More information about the parrot-commits mailing list