[parrot/parrot] c01a0a: Make readline() always return complete lines inste...

GitHub noreply at github.com
Sun Oct 5 07:00:26 UTC 2014


  Branch: refs/heads/gerdr/socket-readline-gh944
  Home:   https://github.com/parrot/parrot
  Commit: c01a0a507ba735cb66f3ca4e111b9a8ac980810d
      https://github.com/parrot/parrot/commit/c01a0a507ba735cb66f3ca4e111b9a8ac980810d
  Author: Gerhard R <gerd.r.devel at googlemail.com>
  Date:   2013-03-12 (Tue, 12 Mar 2013)

  Changed paths:
    M src/io/utilities.c

  Log Message:
  -----------
  Make readline() always return complete lines instead of partial ones, even if we have to block


  Commit: e084eba31c4b01e96d4e722173ac83d660caa182
      https://github.com/parrot/parrot/commit/e084eba31c4b01e96d4e722173ac83d660caa182
  Author: Gerhard R <gerd.r.devel at googlemail.com>
  Date:   2013-03-12 (Tue, 12 Mar 2013)

  Changed paths:
    M src/io/utilities.c

  Log Message:
  -----------
  adjust FIXME comment


  Commit: 243bad2ffdf773bd1bc9cfa1fa6b5a8fef235f65
      https://github.com/parrot/parrot/commit/243bad2ffdf773bd1bc9cfa1fa6b5a8fef235f65
  Author: Gerhard R <gerd.r.devel at googlemail.com>
  Date:   2013-03-12 (Tue, 12 Mar 2013)

  Changed paths:
    M src/io/utilities.c

  Log Message:
  -----------
  Next shot at fixing io_readline_encoded_string().

All regression should be gone and HTTP::Easy still works.
I also identified a potential problem already present in the
original code.


  Commit: 7fac98165f6764f99a740b760204cf36264d62d6
      https://github.com/parrot/parrot/commit/7fac98165f6764f99a740b760204cf36264d62d6
  Author: Gerhard R <gerd.r.devel at googlemail.com>
  Date:   2013-03-13 (Wed, 13 Mar 2013)

  Changed paths:
    M include/parrot/io.h
    M src/io/api.c
    M src/io/filehandle.c
    M src/io/pipe.c
    M src/io/socket.c
    M src/io/stringhandle.c
    M src/io/utilities.c

  Log Message:
  -----------
  Purge set_eof from IO subsystem.

Being at EOF is something the underlying system handle keeps track of, and not
something we should be able to affect from userspace.


  Commit: ab3776eebdab159e531108ec2335cee22003a06d
      https://github.com/parrot/parrot/commit/ab3776eebdab159e531108ec2335cee22003a06d
  Author: Gerhard R <gerd.r.devel at googlemail.com>
  Date:   2013-03-13 (Wed, 13 Mar 2013)

  Changed paths:
    M include/parrot/io.h
    M src/io/buffer.c
    M src/io/utilities.c

  Log Message:
  -----------
  Replace raw_reads from IO_BUFFER with PIO_BF_UNDERFLOW flag


  Commit: 08b1e99e3e34c78b023d09f31078a65fe85ae453
      https://github.com/parrot/parrot/commit/08b1e99e3e34c78b023d09f31078a65fe85ae453
  Author: Gerhard R <gerd.r.devel at googlemail.com>
  Date:   2013-03-13 (Wed, 13 Mar 2013)

  Changed paths:
    M src/pmc/filehandle.pmc
    M src/pmc/handle.pmc
    M src/pmc/socket.pmc
    M src/pmc/stringhandle.pmc

  Log Message:
  -----------
  Implement get_bool(), eof(), is_open() in Handle PMC, not its subclasses


  Commit: 60cf55094609b1c78ebf963402fd1016bbb45d19
      https://github.com/parrot/parrot/commit/60cf55094609b1c78ebf963402fd1016bbb45d19
  Author: Gerhard R <gerd.r.devel at googlemail.com>
  Date:   2013-03-13 (Wed, 13 Mar 2013)

  Changed paths:
    M src/io/filehandle.c

  Log Message:
  -----------
  Set EOF in io_filehandle_read_b()


  Commit: aa8122db48643525490ba26b5a50f65d241b5e4a
      https://github.com/parrot/parrot/commit/aa8122db48643525490ba26b5a50f65d241b5e4a
  Author: Gerhard R <gerd.r.devel at googlemail.com>
  Date:   2013-03-13 (Wed, 13 Mar 2013)

  Changed paths:
    M t/pmc/filehandle.t

  Log Message:
  -----------
  Change test to match new get_bool() semantics


  Commit: bf0701abf61881b12a5e529420d0dde5432854be
      https://github.com/parrot/parrot/commit/bf0701abf61881b12a5e529420d0dde5432854be
  Author: Gerhard R <gerd.r.devel at googlemail.com>
  Date:   2013-03-13 (Wed, 13 Mar 2013)

  Changed paths:
    M src/io/api.c

  Log Message:
  -----------
  Fix bug in Parrot_io_readline_s()

io_verify_has_read_buffer() expects a flags argument, not the buffer size


  Commit: 265980fc3c7360fda92cbb15a010122a0b6a4d70
      https://github.com/parrot/parrot/commit/265980fc3c7360fda92cbb15a010122a0b6a4d70
  Author: Gerhard R <gerd.r.devel at googlemail.com>
  Date:   2013-03-13 (Wed, 13 Mar 2013)

  Changed paths:
    M src/io/socket.c

  Log Message:
  -----------
  Consider buffered sockets at EOF if the last read failed


  Commit: 65674cd15a11b01cd381cd58a0d7b89f502df51a
      https://github.com/parrot/parrot/commit/65674cd15a11b01cd381cd58a0d7b89f502df51a
  Author: Gerhard R <gerd.r.devel at googlemail.com>
  Date:   2013-03-13 (Wed, 13 Mar 2013)

  Changed paths:
    M src/io/buffer.c
    M src/io/utilities.c

  Log Message:
  -----------
  Check for is_eof() in io_readline_encoded_string() instead of the prior hack


  Commit: d74b834bea4f97d2b2ff7b9d16365d305cbe2cd2
      https://github.com/parrot/parrot/commit/d74b834bea4f97d2b2ff7b9d16365d305cbe2cd2
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-10-04 (Sat, 04 Oct 2014)

  Changed paths:
    M include/parrot/io.h
    M src/io/api.c
    M src/io/buffer.c
    M src/io/socket.c
    M src/io/stringhandle.c
    M src/io/utilities.c
    M src/pmc/filehandle.pmc
    M src/pmc/handle.pmc
    M src/pmc/socket.pmc
    M src/pmc/stringhandle.pmc
    M t/pmc/filehandle.t

  Log Message:
  -----------
  Merge branch 'fix-socket-readline' of https://github.com/gerdr/parrot into gerdr/socket-readline-gh944

Conflicts:
	src/io/filehandle.c
	src/io/pipe.c
	src/io/socket.c
	src/io/stringhandle.c
	src/io/utilities.c
	src/pmc/filehandle.pmc
	src/pmc/socket.pmc
	src/pmc/stringhandle.pmc


  Commit: 58a7c68e9463cd92f8df589035bfbaaf5a436e1d
      https://github.com/parrot/parrot/commit/58a7c68e9463cd92f8df589035bfbaaf5a436e1d
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-10-05 (Sun, 05 Oct 2014)

  Changed paths:
    M src/io/buffer.c
    M src/io/filehandle.c
    M src/io/pipe.c
    M src/io/socket.c
    M src/io/stringhandle.c
    M src/io/utilities.c
    M src/pmc/filehandle.pmc
    M src/pmc/socket.pmc

  Log Message:
  -----------
  More fixups for the merge of gerdr/fix-socket-readline

All tests pass, but ./parrot_nci_thunk_gen hangs after having written the buffer.


Compare: https://github.com/parrot/parrot/compare/c01a0a507ba7^...58a7c68e9463


More information about the parrot-commits mailing list