[parrot/parrot] 2c4948: [pmc] rpa: fix invalid read in delete_keyed_int, o...

GitHub noreply at github.com
Tue Dec 2 22:08:43 UTC 2014


  Branch: refs/heads/smoke-me/rpa-offset-gh1152
  Home:   https://github.com/parrot/parrot
  Commit: 2c4948572c2cccdf2fb23d8a69c0053ba20e573e
      https://github.com/parrot/parrot/commit/2c4948572c2cccdf2fb23d8a69c0053ba20e573e
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-12-02 (Tue, 02 Dec 2014)

  Changed paths:
    M src/pmc/resizablepmcarray.pmc

  Log Message:
  -----------
  [pmc] rpa: fix invalid read in delete_keyed_int, off by one

with (1,9,10) and key=1 we read one too far.
repro:
  valgrind ./parrot_old -t20 t/compilers/pge/p5regex/p5rx.t


  Commit: e4fe79c647a01b5fb3bb86b9fa4355fca595924b
      https://github.com/parrot/parrot/commit/e4fe79c647a01b5fb3bb86b9fa4355fca595924b
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-12-02 (Tue, 02 Dec 2014)

  Changed paths:
    M src/pmc/resizablepmcarray.pmc

  Log Message:
  -----------
  [pmc] rpa: shift optim, use data struct directly

do not use seperate SELF and temp values for the attrs.
2.40% faster on my mac, %ebp addressing for data.


  Commit: 73aacbb414a9af5ff2ce5a7b2ad08bde1446fed7
      https://github.com/parrot/parrot/commit/73aacbb414a9af5ff2ce5a7b2ad08bde1446fed7
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-12-02 (Tue, 02 Dec 2014)

  Changed paths:
    M src/pmc/resizablepmcarray.pmc

  Log Message:
  -----------
  [pmc] rpa: internal rename trace macros

add TRACE_RPAdata


Compare: https://github.com/parrot/parrot/compare/bd63ea782e0d...73aacbb414a9


More information about the parrot-commits mailing list