[parrot/parrot] fbc781: [codingstd] include/parrot/atomic/gcc_x86.h c_inde...

GitHub noreply at github.com
Thu Jan 22 09:43:48 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/parrot/parrot
  Commit: fbc7817ca2f3268f3f156ad923448c917ad746b5
      https://github.com/parrot/parrot/commit/fbc7817ca2f3268f3f156ad923448c917ad746b5
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2015-01-22 (Thu, 22 Jan 2015)

  Changed paths:
    M include/parrot/atomic/gcc_x86.h

  Log Message:
  -----------
  [codingstd] include/parrot/atomic/gcc_x86.h c_indent.t


  Commit: aae3b13bffa3368093910c00f714c00e76722be4
      https://github.com/parrot/parrot/commit/aae3b13bffa3368093910c00f714c00e76722be4
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2015-01-22 (Thu, 22 Jan 2015)

  Changed paths:
    M include/parrot/atomic/gcc_x86.h
    M src/atomic/gcc_x86.c

  Log Message:
  -----------
  [atomic] cannot mix PARROT_EXPORT + PARROT_INLINE

remove the INLINE


  Commit: 606d9fd076fd126955e5a798b2705c2e595af7e8
      https://github.com/parrot/parrot/commit/606d9fd076fd126955e5a798b2705c2e595af7e8
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2015-01-22 (Thu, 22 Jan 2015)

  Changed paths:
    M include/parrot/pobj.h
    M src/pmc/resizablepmcarray.pmc

  Log Message:
  -----------
  [pmc] rpa: fix custom_mark_destroy confusion

custom_mark_destroy is only needed in the init method, which is fpa.set_integer_native.
optimize PObj_custom_mark_destroy_SETALL to use only one setter call.


  Commit: bf01f77f8e141fd33d681ce6ef5993a3f31e3697
      https://github.com/parrot/parrot/commit/bf01f77f8e141fd33d681ce6ef5993a3f31e3697
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2015-01-22 (Thu, 22 Jan 2015)

  Changed paths:
    M include/parrot/packfile.h
    M src/gc/mark_sweep.c
    M src/packfile/api.c

  Log Message:
  -----------
  [GC] fix GC segfault with --optimize

A wrong PARROT_CANNOT_RETURN_NULL in Parrot_pf_get_current_code_segment
(unchecked return of inter->code, which can be null) causes GC segfaults
when inter->code == NULL.

Fixes GH #1186.
This wrong PARROT_CANNOT_RETURN_NULL was added with 3.6.0
in 7dc0e2276d3612afd at Wed Jun 29 20:52:24 2011
but started being fatal after the new packfile refactor with 7.0,
when the cc optimizer started optimizing away the bc != NULL check
in mark_code_segment()


  Commit: c73b9b88cabaa030465f7b04b08e4b09763896eb
      https://github.com/parrot/parrot/commit/c73b9b88cabaa030465f7b04b08e4b09763896eb
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2015-01-22 (Thu, 22 Jan 2015)

  Changed paths:
    M src/gc/mark_sweep.c

  Log Message:
  -----------
  [GC] optimize away a Parrot_pf_get_current_code_segment call

This was the call with the wrong CANNOT_RETURN_NULL attribute, causing GH #1186.
We only need inter->code, and it can be const. The const_table also


  Commit: 05dc43fc8b4c96f2cdb8bb8fdf35b3e11b839e9a
      https://github.com/parrot/parrot/commit/05dc43fc8b4c96f2cdb8bb8fdf35b3e11b839e9a
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2015-01-22 (Thu, 22 Jan 2015)

  Changed paths:
    M src/gc/gc_gms.c

  Log Message:
  -----------
  [threads] fix deadlock in gc_gms_mark_and_sweep

move the lock downwards to the guard. Fixes GH #1187


Compare: https://github.com/parrot/parrot/compare/38eef0895b95...05dc43fc8b4c


More information about the parrot-commits mailing list