codetest failures (make -k fulltest) at r38999

[James E Keenan]

Michael Hind wrote:
> make -k fulltest fails codetest all others PASS - Kubuntu Jaunty (9.04) 
> at r38999
> 
> patch for some failures at http://nopaste.snit.ch/16628
> 
> The Pod failure seems to be line 216/217 {{Note...}} of 
> docs/pdds/pdd24_events.pod
> but it passes podchecker
> 
> I couldn't track down the src/pmc/packfileannotations.pmc problem

Corrected.

> 
> ----------------------------------------
> 
> #   Failed test 'there should be at least one space between a C
> # keyword and any subsequent open parenthesis
> # '
> #   at t/codingstd/c_parens.t line 111.
> #          got: '/home/mhj64/parrot.t/src/packfile.c: switch(
> # /home/mhj64/parrot.t/src/packfile.c: if('
> #     expected: ''
> # Looks like you failed 1 test of 3.
> t/codingstd/c_parens.t .........
> Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/3 subtests
> 

Couldn't reproduce.  Perhaps already fixed.

> 
> t/codingstd/copyright.t ........
> not ok 2 - Copyright statement in the right format # TODO Waiting for 
> full transition to Parrot Foundation
> ok 3 - Duplicate Copyright statements # TODO duplicate copyrights exist.
> ok
> 
> 

Couldn't reproduce.  (But note that we are getting different results 
between 5.8's prove and 5.10's.)


> #   Failed test 'Test::Perl::Critic for 
> "/home/mhj64/parrot.t/lib/Parrot/Docs/File.pm"'
> #   at t/codingstd/perlcritic.t line 88.
> #
> # Perl::Critic found these violations in 
> "/home/mhj64/parrot.t/lib/Parrot/Docs/File.pm":
> # Found trailing whitespace at 
> /home/mhj64/parrot.t/lib/Parrot/Docs/File.pm line 1
> # Looks like you failed 1 test of 307.
> t/codingstd/perlcritic.t .......
> Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/307 subtests
>

Couldn't reproduce; perhaps already fixed.

> 
> #   Failed test 'Pod syntax correct'
> #   at t/codingstd/pod_syntax.t line 45.
> #          got: 'docs/pdds/pdd24_events.pod'
> #     expected: ''
> # You should use podchecker to check the failed files.
> # Looks like you failed 1 test of 2.
> t/codingstd/pod_syntax.t .......
> Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/2 subtests
> 
> 
Fixed.

> #   Failed test 'no trailing whitespace'
> #   at t/codingstd/trailing_space.t line 49.
> # Trailing space or tab char found in the following files:
> # /home/mhj64/parrot.t/src/pmc/packfileannotations.pmc 266, 334, 348, 349
> # /home/mhj64/parrot.t/lib/Parrot/Docs/File.pm 392
> # That's 2 failed files out of 1111 files total.
> # Looks like you failed 1 test of 1.
> t/codingstd/trailing_space.t ...
> Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/1 subtests
> 

Fixed.

So 'make codetest' is PASS for me.