[svn:parrot] r43819 - in branches/rm_cflags/src: . call runcore

chromatic chromatic at wgz.org
Tue Feb 9 19:14:10 UTC 2010


On Tuesday 09 February 2010 at 07:24, coke  wrote:

> Log:
> Eliminate some unused variables and static functions.
> 
> Most interesting one is the string creation inside the loops in 
src/call/args.c
> - might be worth a benchmark on trunk.

> @@ -823,7 +822,6 @@
>      GETATTR_FixedIntegerArray_int_array(interp, raw_sig, int_array);
>  
>      for (arg_index = 0; arg_index < arg_count; arg_index++) {
> -        STRING * const signature = CONST_STRING(interp, "signature");
>          const INTVAL arg_flags = int_array[arg_index];
>          const INTVAL raw_index = raw_args[arg_index + 2];
  
If you mean this one, there's likely little effect.  CONST_STRING is a macro 
which expands to a lookup inside a C array in the interpreter.  Hoisting it 
out of the loop avoids a few pointer dereferences.

-- c


More information about the parrot-dev mailing list