[PATCH] Re: vtable_massacre branch needs more eyes
Andrew Whitworth
wknight8111 at gmail.com
Sat Feb 13 16:02:16 UTC 2010
Yes, I'm thinking it might be the skip count that's wrong too. The
patch does look sane. I'll test it out and hopefully have a fix
committed within the hour.
--Andrew Whitworth
On Sat, Feb 13, 2010 at 10:58 AM, Andy Dougherty <doughera at lafayette.edu> wrote:
> On Sat, 13 Feb 2010, James E Keenan wrote:
>
>> Andy Dougherty wrote:
>> > With this branch at Revision: 43921 on Solaris, I got two new sets of
>> > failure. Both look like bad plans -- the "List of Failed" are all
>> > greater
>> > than the "Total".
>> >
>> > Failed Test Stat Wstat Total Fail List of Failed
>> >
>> > -------------------------------------------------------------------------------
>> > t/op/arithmetics_pmc.t 44 12 45-56
>> > t/pmc/bigint.t 34 11 35-45
>>
>> r43921 was the point at which the branch was merged back into trunk. At
>> this same revision, I am getting the same problem as Andy in t/pmc/bigint.t
>> on Darwin/PPC, but not on Linux/i386. (I am not getting failures in
>> t/op/arithmetics_pmc.t on either box.)
>
>> Now, I've been getting that "Buggy GMP" message -- and hence, SKIPping
>> tests -- on this test file for years. But I never got a FAIL due to some
>> problem in test counting until now. When this was still in the branch, I
>> got this problem on Darwin/PPC and changed the number of tests in the plan
>> to 45, at which point all the tests were correctly SKIPped and the file as
>> a whole PASSed.
>>
>> But apparently that was the wrong thing to do and someone changed it back
>> to 34 before the merge.
>
> I suspect it's the skip count that's wrong, not the plan. Is this patch
> correct?
>
> diff -r -u parrot-current/t/op/arithmetics_pmc.t parrot-andy/t/op/arithmetics_pmc.t
> --- parrot-current/t/op/arithmetics_pmc.t 2010-02-12 22:29:44.000000000 -0500
> +++ parrot-andyt/op/arithmetics_pmc.t 2010-02-13 10:53:26.149777412 -0500
> @@ -34,7 +34,7 @@
> run_tests_for('Float')
>
> if gmp goto do_big_ones
> - skip( 34, "will not test BigInt or BigNum without gmp" )
> + skip( 22, "will not test BigInt or BigNum without gmp" )
> goto end
>
> do_big_ones:
> diff -r -u parrot-current/t/pmc/bigint.t parrot-andy/t/pmc/bigint.t
> --- parrot-andy/t/pmc/bigint.t 2010-02-12 22:29:43.000000000 -0500
> +++ parrot-current/t/pmc/bigint.t 2010-02-13 10:55:13.661777461 -0500
> @@ -77,14 +77,14 @@
>
> NoLibGMP:
> say 'No BigInt Lib configured'
> - skip(45)
> + skip(34)
> exit 0
>
> OldLibGMP:
> print 'Buggy GMP version ['
> print $S3
> say '] with huge digit multiply - please upgrade'
> - skip(45)
> + skip(34)
> exit 0
>
> ret:
> @@ -535,7 +535,7 @@
> eq $I0, 4, sz4
> print 'Cannot cope with sizeof(INTVAL) == '
> say $I0
> - skip(43)
> + skip(34)
> exit 1
>
> sz8:
>
>
> --
> Andy Dougherty doughera at lafayette.edu
> _______________________________________________
> http://lists.parrot.org/mailman/listinfo/parrot-dev
>
More information about the parrot-dev
mailing list