[svn:parrot] r44270 - trunk/src
Michael Hind
mike.hind at gmail.com
Sun Feb 21 09:49:22 UTC 2010
chromatic - this cast is required to build with g++
I had to restore it in r44276
I am sure there could be another solution to this problem.
On 21 February 2010 04:06, <chromatic at svn.parrot.org> wrote:
> Author: chromatic
> Date: Sun Feb 21 04:06:41 2010
> New Revision: 44270
> URL: https://trac.parrot.org/parrot/changeset/44270
>
> Log:
> [src] Removed unnecessary cast when parsing tracing flags in parseflags().
> Not
> only does it generate compiler warnings about the enumeration, but it gives
> a
> false sense of security that we've done any argument checking there.
>
> Modified:
> trunk/src/main.c
>
> Modified: trunk/src/main.c
>
> ==============================================================================
> --- trunk/src/main.c Sun Feb 21 04:06:33 2010 (r44269)
> +++ trunk/src/main.c Sun Feb 21 04:06:41 2010 (r44270)
> @@ -477,7 +477,7 @@
> break;
> case 't':
> if (opt.opt_arg && is_all_hex_digits(opt.opt_arg))
> - *trace = (Parrot_trace_flags)strtoul(opt.opt_arg, NULL,
> 16);
> + *trace = strtoul(opt.opt_arg, NULL, 16);
> else
> *trace = PARROT_TRACE_OPS_FLAG;
> break;
> _______________________________________________
> http://lists.parrot.org/mailman/listinfo/parrot-commits
>
--
Michael H. Hind
Tel: +44 (0) 1224 631 581
Cell: +44 (0) 7877 224 745
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.parrot.org/pipermail/parrot-dev/attachments/20100221/9983794a/attachment.htm>
More information about the parrot-dev
mailing list