Comparison of encoding with encoding _number_ in r48994

Lithos sohtil at gmail.com
Tue Sep 14 09:15:49 UTC 2010


Hi!

It looks like after this change in r48994

-    if (size || (!STRING_IS_NULL(s) && s->encoding !=
CONST_STRING(interp, "")->encoding))
+    if (size || (encoding != CONST_STRING(interp, "")->encoding->num))

the code is now comparing a const STR_VTABLE * to an int (encoding->num).
Seems wrong to me.

best regards

Lithos


More information about the parrot-dev mailing list