config/auto/sizes.pm: Unused code

James E Keenan jkeen at verizon.net
Fri Jun 1 16:31:14 UTC 2012


Friends,

Today when I performed a 'git pull' I noticed that there had been 
updates to config/auto/sizes.pm and t/steps/auto/sizes.t.  I believe 
these updates were written several months ago, mostly by Gerhard R., but 
only recently merged into master.  I ran coverage analysis which you can 
view starting here: 
http://thenceforward.net/parrot/coverage/configure-build/coverage.html

Examining the coverage report for auto::sizes 
(http://thenceforward.net/parrot/coverage/configure-build/config-auto-sizes-pm.html), 
I noticed that internal subroutine _find_type_ge() was completely 
uncovered.  This meant that not only was there nothing in the test file 
invoking it -- there was nothing in the module invoking it either! 
Examination of config/auto/sizes.pm confirmed that the subroutine is 
defined but never used.

In general we should not retain code in the configuration system that we 
are not currently invoking.  Is there any reason why we should retain 
this subroutine?  If not, then I will remove it as part of looking at 
the module to see if there is any other still-uncovered code we can 
write tests for.

Thank you very much.
Jim Keenan



More information about the parrot-dev mailing list