config/auto/sizes.pm: Unused code
Gerhard R.
gerd.r.devel at googlemail.com
Fri Jun 1 19:02:13 UTC 2012
Hi, and sorry for replying out-of-thread.
> I noticed that internal subroutine _find_type_ge() was completely
> uncovered. This meant that not only was there nothing in the test file
> invoking it -- there was nothing in the module invoking it either!
That's a result of commit https://github.com/parrot/parrot/commit/762dddd5
> Is there any reason why we should retain this subroutine?
No. I just failed to remove the sub when replacing its single invocation
with a call to _find_type_min_ge().
> If not, then I will remove it as part of looking at the module to see
> if there is any other still-uncovered code we can write tests for.
Thanks for picking up my slack - much appreciated.
Gerhard R.
More information about the parrot-dev
mailing list